fix(test): e2e suite silently skips every test - #2585
Conversation
|
@jjamroga, made the suitable changes PTAL |
|
You need to avoid running the e2e tests in the unit tests job |
|
And sign the DCO |
4dbe7a7 to
14b87a6
Compare
EItanya
left a comment
EItanya
left a comment
There was a problem hiding this comment.
SOrry, but can we re-add TestE2E to the prefix of the e2e tests like we had before. Build tags can be a little annoying locally
10721f8 to
62f65e6
Compare
|
Hi @EItanya, made the reqd changes PTAL |
|
Unit tests are still failing |
d3f532b to
5e8db37
Compare
Just made the changes, tests should work properly now |
ad931eb to
b640a86
Compare
|
I have changed -skips to -tags, this should now not skip any test |
0e92a91 to
9e14e40
Compare
|
@EItanya, have tested it locally and it works now |
supreme-gg-gg
left a comment
supreme-gg-gg
left a comment
There was a problem hiding this comment.
Hi @ekam-walia you need to also rename e2e tests in mcp_test.go so they're skipped in unit tests properly
aa65a30 to
8366fab
Compare
Signed-off-by: ekam-walia <164983405+ekam-walia@users.noreply.github.com>
8366fab to
0f8b62b
Compare
|
Hi @supreme-gg-gg, I have made every change that was reqd for this PR |
3 participants
This PR includes is the fix of issue #2580
I have changed t.Skip() to t.Fatalf() so the test fails loudly when the environment variable is missing. CI already sets KAGENT_GRPC_URL as a fallback (line 142 in .github/workflows/ci.yaml), so CI continues to work.
Fixes #2580