chore(deps): replace unmaintained wk8/go-ordered-map with pb33f fork - #2642
Open
dimetron wants to merge 2 commits into
Open
chore(deps): replace unmaintained wk8/go-ordered-map with pb33f fork#2642dimetron wants to merge 2 commits into
dimetron wants to merge 2 commits into
Conversation
wk8/go-ordered-map is unmaintained; pb33f/ordered-map is the maintained fork with the same package path and API. It is still pulled into the graph transitively by ollama/ollama and gosec, so a replace directive is needed (same approach as lima-vm/lima#4916). go mod tidy also promotes charmbracelet/x/ansi to a direct dependency, as it is imported directly by core/cli/internal/tui/panels.go. Signed-off-by: Dmytro Rashko <dimetron@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a
replacedirective swapping the unmaintainedgithub.com/wk8/go-ordered-map/v2for its maintained forkgithub.com/pb33f/ordered-map/v2(same package path and API). Same approach as lima-vm/lima#4916.Why
wk8/go-ordered-mapis unmaintained. It is still pulled into the module graph transitively byollama/ollama(viainternal/orderedmap) andsecurego/gosec(via golangci-lint), so a plain version bump cannot remove it — areplaceis required. Neither upstream has dropped it yet (checked: Ollama v0.33.2 still requires it).Details
replace github.com/wk8/go-ordered-map/v2 => github.com/pb33f/ordered-map/v2 v2.1.8v2.1.8is pb33f's fork of wk8 v2.1.8, API-identical.v2.3.1cannot be used here: it is already in the graph under its own path (viainvopop/jsonschema/ Anthropic SDK), and Go refuses to serve one module version under two paths.go mod tidydrops the wk8 hashes fromgo.sumand adds pb33f v2.1.8.charmbracelet/x/ansipromoted from indirect to direct — it is imported directly bygo/core/cli/internal/tui/panels.go.Verification
go mod tidy— cleango build ./...— passgo test ./adk/pkg/embedding/...(pulls in Ollama) — passgo vet ./adk/pkg/...— passgo mod verify— all modules verified