fix(otel): restore distributed tracing for the controller and agent runtimes - #2663
Merged
EItanya merged 6 commits intoSep 2, 2026
Merged
Conversation
github-actions
Bot
added
bug
codyhartsook
marked this pull request as ready for review
September 1, 2026 23:22
krisztianfekete
left a comment
krisztianfekete
left a comment
Contributor
There was a problem hiding this comment.
This is looking very good, added some comments on potentially improving what we had before.
Comment on lines
+82
to
+83
| // otelgrpc snapshots the global TracerProvider and propagator when its handler | ||
| // is constructed, so tracing has to be registered before any server is built. |
Contributor
There was a problem hiding this comment.
Great thing to call out, thanks!
Comment on lines
+14
to
+30
| func OtelEnvFromProcess() []corev1.EnvVar { | ||
| var envVars []corev1.EnvVar | ||
| for _, envVar := range os.Environ() { | ||
| if !strings.HasPrefix(envVar, "OTEL_") { | ||
| continue | ||
| } | ||
| name, value, found := strings.Cut(envVar, "=") | ||
| if !found { | ||
| continue | ||
| } | ||
| envVars = append(envVars, corev1.EnvVar{Name: name, Value: value}) | ||
| } | ||
| slices.SortFunc(envVars, func(a, b corev1.EnvVar) int { | ||
| return strings.Compare(a.Name, b.Name) | ||
| }) | ||
| return envVars | ||
| } |
Contributor
There was a problem hiding this comment.
I know that we had a similar logic before it got removed, but wondering if we should go with an explicit allow-list for OTel env vars instead.
What I mainly want to avoid is silently adding potentially unwanted data as plaintext e.g. when someone decides to propagate OTEL_EXPORTER_OTLP_HEADERS.
There might also be a problem if someone is setting a e.g. service.name via an env var as well, as that would falsely label agents after the var is propagated.
Contributor
Author
There was a problem hiding this comment.
good idea, added the allow list.
Comment on lines
+46
to
+47
| // "none" selects a noop exporter, so the test dials no collector. | ||
| t.Setenv("OTEL_TRACES_EXPORTER", "none") |
Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>
Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>
Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>
Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>
codyhartsook
force-pushed
the
address-tracing-regression-oss
branch
from
September 2, 2026 15:01
8a538ce to
5aad890
Compare
Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>
EItanya
approved these changes
Sep 2, 2026
EItanya
enabled auto-merge (squash)
September 2, 2026 16:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores distributed tracing for the v2 controller and the established kagent runtime.
OTEL_*variables into kagent runtime revisions; tracing configuration therefore participates in the revision digest.Verification
go test ./core/...make -C go lintgo test ./core/internal/telemetry ./core/v2/translator ./core/v2/translator/kagent ./core/v2/translator/claudekagent-controllerinto the actor.Deferred
Claude harness tracing needs runtime telemetry initialization and its mock E2E fixture/image from #2602. That work will be handled with the new harness rather than broaden this controller regression fix.