Skip to content

chore(bench): record the review-code last-push replacement run - #131

Merged
kamui merged 13 commits into
mainfrom
t3code/issue-30-review-code-last-push
Oct 12, 2026
Merged

kamui merged 13 commits into
mainfrom
t3code/issue-30-review-code-last-push

Conversation

@kamui

@kamui kamui commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

Why

Record the 30-cell last-push run of review-code-sonnet-5-5 so #30 can later replace its saved reviews and remove the three matching off-roster built-ins. Share its complete execution evidence through an immutable public release. Selection and grading follow separately.

Scope

  • bench/runs/2026-10-12-last-push-claude-review-code-sonnet/: frozen inputs, provenance, 31 attempts, five diagnoses and transcript mappings.
  • docs/research/last-push-review-code-2026-10-12/: run plan, queue files, accounting and evidence disclosure authorization.
  • bench/tools/review_queue.py and test_review_queue.py: accept the kept cause reviewer-stop.
  • bench/evidence/manifests/last-push-review-code-transcripts-2026-10-12-v1.json, its restoration receipt and .gitignore: retrieve all 31 exact archives from release storage.

Result: 26 valid reviews, four kept stops, 55 comments and $25.83 list price against a $60 cap.

Tradeoffs

The first attempt hit the sandbox socket path limit and was replaced using a shorter work root. Four reviews ended without a result after a command refusal; their stops remain their cell results. Failed evidence and replacement usage are preserved. The client listed 15 stock account skills beside the pinned skill, although none was invoked. The record discloses this clean-context limitation.

Blast Radius

Current grading and the published selection remain unchanged. The queue adds one accepted cause without changing existing verdicts. Preserve branch history because it retains frozen commit 764cd032. Public transcript disclosure, including recorded account metadata and a preview URL, has explicit owner approval.

Verification

  • At 9a5e436c, bun run verify:import passed.
  • A fresh clone at 9a5e436c retrieved all 31 transcripts with tools/collect_run.py; frozen hashes matched.
  • evidence_store.py verify downloaded the exact published package into an empty temporary directory and verified every member. Restoration receipt.
  • Initial run checks and the known local benchmark-suite failure are recorded in the run report.

Part of #30

kamui added 12 commits October 11, 2026 23:40
One run replaces the saved review-code reviews of the ten re-cut tasks, 30 reviews on Sonnet 5.5, as the owner approved on 2026-10-11. It keeps the saved arm file, skill tree, execution policy and per-attempt bound, and runs on the client the earlier replacement runs used.

The files of the pinned skill tree are in the run's inputs. This repository held no object of that tree, so the runner could not extract it.

Part of #30. Refs #60.
The manifest names 764cd03 as its freeze commit. The record says how the run was defined, what it pins, its $60 cap under the $519.93 left of the Claude ceiling, the checks that passed and what the first review still has to show. No review has started.

Part of #30. Refs #60.
…ent run

The run finished on 2026-10-12 at 06:04 UTC with 31 attempts: 26 valid reviews, four reviews kept after the reviewer ended its session without a result, and one attempt the harness stopped and att-002 replaced. Priced usage is $25.83 of the $60 cap.

transcripts.json maps the 31 attempts to their transcript archives. The archives are not in release storage yet, and Git ignores their paths.

Part of #30. Refs #60.
The record and the run's README now give the results by task, the five attempts without a result and what was decided for each, the queue's second version, the usage, what the first review showed, the cleanup state and what is not done.

The transcript archives are packed for the release evidence-last-push-review-code-transcripts-2026-10-12-v1 and not published. The run is not in the registry, and the four kept stops still carry the cause skill-timeout.

Part of #30. Refs #60.
…w-code-last-push

* origin/main:
  feat(grading): stop the grading queue at the plan's quota limit (#129)
  fix(grading): blind a review's source links under any work root (#127)
…bel the four in the review-code run

review_queue.py gains the kept cause reviewer-stop, a reviewer that ended
its own session without a result. The four reviews of the review-code
last-push run that gave up after one refused command were filed under
skill-timeout while the run was frozen, as the owner chose, and now carry
the new cause.

@kamui kamui left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Requested (advisory) — 1 must-fix finding.

Findings

Reviewed 9be8a11. All 417 changed files accounted for. Reviewed run metadata, prompts, accounting, diagnoses, queue behavior and test coverage; the imported skill was verified by pinned tree and provenance hashes. Required independent verification is complete.

Review details

Intent: Record the last-push review-code replacement run and keep reviewer-stop attempts as cell results.

Issue fit: The scoped contribution to #30 is recorded, with selection and grading left for separate work. The base evidence-sharing requirement remains unmet.

Reviewed: 9be8a11 against merge-base 914a5f5.

Checks:

  • Exact-head CI passed, including the changed reviewer-stop test and 919 benchmark tests with 18 skips.
  • Read-only checks matched the run counts, $25.826306 total, frozen inputs and 31 pinned packets. A clean-tree transcript collection failed because the new archives are unavailable.
  • PR-reported local checks without exact-head logs were not reused as proof.

@kamui

kamui commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

Addressed at 9a5e436c395d98ce542f8c8874edd634ba3aafcc. One implemented item in 9a5e436c.

Checks at this clean tracked head: bun run verify:import passed, and tools/collect_run.py --run bench/runs/2026-10-12-last-push-claude-review-code-sonnet retrieved and verified all 31 transcripts in a fresh clone with no initial archives or cache. evidence_store.py verify passed against the same committed manifest bytes using an empty temporary directory, checking remote identity, archive and member hashes, sizes and permissions. No behavioral code changed in this round.

The independent review of this head and the reply drafts completed with no blocking defects or unsupported claims. Updated the PR description for the published manifest and restoration receipt. The thread is resolved, with no remaining feedback or verification gap for this fix. The round is finished.

Re-requesting review from @kamui.

@kamui
kamui merged commit c6a13d4 into main Oct 12, 2026
4 checks passed
@kamui
kamui deleted the t3code/issue-30-review-code-last-push branch October 12, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant