[daily] refactor: hoist knownPlugins to module-level KNOWN_PROW_PLUGINS constant - #112
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
The plugin name list used in extractPlugins() and extractOrgPlugins() was defined twice as an identical local const, with a comment warning the two copies must stay in sync. Move the list to a single module-level constant (KNOWN_PROW_PLUGINS) and reference it from both functions. The comment clarifying that it must match prow-plugin-map.js is preserved on the module-level declaration. All 152 unit tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
background.jscontained two identical localconst knownPluginsdeclarations — one inextractOrgPlugins()and one inextractPlugins()— with a comment warning both copies must stay in sync withprow-plugin-map.js. This was a latent bug: adding a plugin to the map required remembering to update two separate arrays.Change
Moved the list to a single module-level constant
KNOWN_PROW_PLUGINSand updated both functions to reference it. The "must stay in sync with prow-plugin-map.js" note is preserved on the single declaration.extractOrgPluginsandextractPluginseach now iterate overKNOWN_PROW_PLUGINSinstead of their own locally-scoped copy.Testing
All 152 unit tests pass (
npm test).