DOC: Clarify Strategy.sell bullet and document Trade.close() quantization - #1391
Open
OllyNewport wants to merge 2 commits into
Open
DOC: Clarify Strategy.sell bullet and document Trade.close() quantization#1391OllyNewport wants to merge 2 commits into
OllyNewport wants to merge 2 commits into
Conversation
…tion Addresses remaining parts of kernc#1318: - kernc#17: clarify the OR/AND relationship between the two bullet conditions in Strategy.sell's caution note (the the/leverge typos were already fixed in 054d453). - kernc#5: document that Trade.close() rounds portion to at least one whole unit, so it can close more of a small trade than requested. kernc#20 needed no change: the deprecated code containing the 'Backtesting 0.2.0' message was removed entirely in 2a1f33c. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the remaining parts of #1318:
conditions in
Strategy.sell's caution note (the "the the"/"leverge"typos were already fixed in 054d453).
Trade.close()roundsportionup to atleast one whole unit, so it can end up closing more of a small
trade than requested.
#20 needed no change — the deprecated code containing the
"Backtesting 0.2.0" message was removed entirely in 2a1f33c, so
there's nothing left with a spacing issue.