[masnwilliams]

Summary

On iPhone, tapping an AutoFill suggestion (for example your email above the keyboard) in a live view email field types it into the remote field two or three times.

Email, tel and code fields send each input event's text to the remote as keys and then reset the overlay to its one-character sentinel. iOS fills a field by replacing its text, and it can take more than one edit to do it, or fill again once the overlay's value changes under it. Each of those edits was sent as new text.

Changes

• field-keyboard.ts: fields that offer AutoFill (email, tel, one-time-code, and contact fields such as name and address) keep their text in the overlay, the way autocorrect fields already do since Open the live view's soft keyboard from the remote browser's focus #464. Edits are diffed against what was sent, so a fill reaches the remote as backspaces and the missing text, however many edits it takes. Password, username, url and number fields keep the per-key path. So does the default keyboard, used when no field is known (the keyboard button, the address bar, or a focus held before the field is reported), since it offers codes from Messages.
• typed-text.ts: a value that no longer starts with the sentinel but is not empty means AutoFill replaced the whole value, sentinel included. That is new text, not a deletion of what came before, so no backspace is sent for the sentinel and the overlay is not reset.
• video.vue: in that case the sentinel is put back in front of the filled text instead of resetting the overlay, so a later backspace past the start is still seen.

Testing

• bun test tests: 259 pass. New tests replay the fill sequences this has to handle through the real onOverlayInput, TypedText and TextInput: one replacement of the whole value, the same fill repeated three times, a space inserted before the replacement, and a fill that completes typed letters. All of them type the email exactly once, and a code filled twice on the default keyboard is typed once. The four component tests fail on main (the repeated fill types it three times).
• Lint shows no new warnings compared with main.
• Replayed the repeated fill through the live view against a production browser: the remote email field got the address once with this change, and three times with the deployed client.
• Tested on a physical iPhone, in Safari and in Chrome, against a production browser serving the deployed live view client with this change and Stop reloading the live view video on every interaction in iOS browsers #487 hot-patched in. Picking the email AutoFill suggestion in the live view puts it in the remote field once, in both browsers. That run predates the default-keyboard commit, which was checked in Chromium with iPhone emulation on the same browser: a code filled twice into the address bar arrived once, and a URL typed there plus Enter navigated.

---

Note

Medium Risk
Changes touch input routing for several field types on iOS; wrong diff or sentinel handling could mis-sync remote text, but scope is limited to the overlay keep-text path with new tests.

Overview
Fixes duplicate remote typing when iPhone users pick an AutoFill suggestion (email, phone, OTP, contact fields) in the live view touch overlay.

AutoFill-friendly keyboards now use the same keep-text + diff path as autocorrect: field-keyboard sets keepText: true for email, tel, one-time-code, contact autocomplete, and the default keyboard (Messages codes). TypedText.edit treats a full-value replacement (sentinel stripped) as new fill text instead of a sentinel delete. video.vue adds restoreInputSentinel() so after a successful keep-text edit the overlay is sentinel + filled text rather than reset—so repeated iOS fill events and later backspaces still behave correctly. Held-focus keyboard unlock uses DEFAULT_KEYBOARD.keepText instead of forcing false.

Tests cover keyboard keepText rules, TypedText AutoFill sequences, and component-level onOverlayInput replays (including triple repeated fills).

^{Reviewed by Cursor Bugbot for commit 39e0c23. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit a647f8a. Configure here.}

[tnsardesai]

LGTM, one small nit.

Design

• Non-blocking nit — replaced can be dropped — images/chromium-headful/client/src/utils/typed-text.ts:L53-L62
  • Problem: The sentinel is never empty, so kept already implies value !== ''. That makes kept || replaced always equal to value !== ''. The new variable and both kept || replaced checks only restate that the one sentinel deletion left is an emptied overlay.
  • Impact: No behavior change, but a reader has to work through three booleans when there's really one condition.
  • Fix: Use const emptied = value === '', send deletes + (emptied ? 1 : 0) backspaces, and return !emptied && next.length <= MAX_TEXT.