[khanhkit]

AP-ISS-0196

Closes the 36 routed HIGH/MEDIUM provider-routing and service OCR findings with current-code terminal dispositions.

• 32 reproduced and fixed with focused regressions
• 3 current-code false positives with executable evidence
• 1 already implemented on accepted main
• preserves fail-closed SSRF, credential, replay/idempotency, routing and queue semantics

Exact source head: 19cdaa0538862a179caa6af8497a92c539d038bf
Current recorded PR base: 08bbb79b5dcbf3823e8826220c771cd7856ae054
Original verified base: c0c91edd8b2b49cfbb5653451ab06bc0b0313d49

Gen60 exact-head revalidation (2026-10-15)

After GoalKeeper activation, Gen60 independently revalidated the pre-activation rebased head without source mutation:

• clean local and remote branch both resolve to 19cdaa0538862a179caa6af8497a92c539d038bf
• all 27 AP-ISS-0196 changed unit-test files: 300/300 PASS, 0 fail/skip/cancel/todo
• npm run typecheck:core: PASS / RC=0
• npm run check:open-sse-typecheck: PASS / RC=0
• npm run check:file-size: PASS / RC=0
• npm run check:provider-consistency: PASS / RC=0
• npm run check:fetch-targets: PASS / RC=0
• PR-context npm run check:test-masking: PASS / RC=0
• npm run test:security: 23/23 PASS / RC=0
• git diff --check 08bbb79b...HEAD: PASS / RC=0
• exact-head CI run 38494376056: SUCCESS, including Lint, all unit/integration/E2E shards, Security Tests, Build/package provenance, Coverage, Quality Ratchet, and extended scanners
• exact-head CodeQL, DAST, API Route Typecheck, and Semgrep: SUCCESS
• exact-head OpenCodeReview run 38494373674 originally failed before review execution due OCR runner/tool packaging (../scripts/platform missing); Gen60 requested attempt 2 after later OCR infrastructure showed a successful execution on another PR. Attempt 2 is queued at this update.

Integration is intentionally fenced: active AP-ISS-0199 also changes open-sse/services/museCodeAuth.ts, and the current KitControl serialization requires AP-ISS-0199 to integrate before AP-ISS-0196 on that shared Muse credential-egress surface. PR #130 must not be rebased/merged across that dependency until AP-ISS-0199 is terminally integrated, after which AP-ISS-0196 needs a fresh exact-head rebase/revalidation and hosted gate cycle.

Fresh Gen57 verification on prior exact tree

The final hosted CI pass on 626b5b849db95c9d222705be63f58a4b7fafaaec exposed three deterministic regressions. Gen57 reproduced all three locally before mutation:

• two self-hosted routing tests returned 502 because they monkeypatched global fetch, while the DNS-pinning hardening intentionally uses the validated-address transport; those tests now exercise the existing real local-server harness instead
• a system-reminder containing fenced code was no longer preserved as one opaque instruction envelope because the custom-pattern fence-intersection guard had also been applied to built-in system envelopes

Current exact-tree verification after the minimal repairs:

• focused final regressions: 27/27 PASS (self-hosted entry, system-reminder preservation, custom cross-fence preservation, agentic tool-result detection/counting)
• npm run typecheck:core: PASS
• npm run check:open-sse-typecheck: PASS / 0 errors
• npm run check:file-size: PASS
• focused ESLint on the current delta: PASS
• git diff --check: PASS
• npm run test:security: 23/23 PASS

The outstanding OpenCodeReview MEDIUM finding is also fixed on this exact head: custom_tool_call_output is recognized by both trailing tool-result detection and active-round counting. Its inline thread has been replied to with exact-SHA evidence and resolved.

Prior final-review verification

On bc9ec2e347154dc7154a22a65cdd5e334bf44801, before the final two follow-up commits:

• final review-focused tests: 99/99 PASS
• npm run typecheck:core: PASS
• npm run check:open-sse-typecheck: PASS / 0 errors
• npm run check:file-size: PASS
• focused ESLint: PASS
• git diff --check: PASS
• npm run check:provider-consistency: PASS
• npm run test:security: 23/23 PASS

That review wave independently reproduced and fixed Responses custom_tool_call_output round counting, cross-fence custom preservation matches, Lyceum optional ancillary metadata handling, and provider-adapter DNS pinning. The Antigravity finding was dispositioned as a false positive against the routed source contract with executable coverage.

Prior full AP-ISS-0196 verification

• changed focused tests: 280/280 PASS
• npm run typecheck:core: PASS
• npm run check:file-size: PASS
• npm run check:open-sse-typecheck: PASS
• npm run check:fetch-targets: PASS
• npm run check:provider-consistency: PASS
• GITHUB_BASE_SHA=c0c91edd... npm run check:test-masking: PASS
• full ESLint with existing suppression policy and --pass-on-unpruned-suppressions: PASS
• npm run test:security: 23/23 PASS
• local Quality Ratchet: PASS, 57 metrics / 3 improved
• git diff --check: PASS

check:routing-error-guard remains red only on pre-existing untouched open-sse/services/combo/* baseline entries; AP-ISS-0196 changes do not overlap those paths.

KitControl evidence: projects/AgentProxy/board/evidence/AP-ISS-0196-terminal-dispositions-g53.md.

[github-actions]

✅ OpenCodeReview: Review complete: 0 finding(s) across 5 selected item(s).

Reviewed 19cdaa0..4251b60 only; earlier commits in this PR were reviewed in a previous run.

[github-actions]

CI Coverage Report

• Coverage job: success
• PR test policy: success

Coverage artifact was not available for this run.