Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions backend/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
plugins {
id("org.springframework.boot") version "4.0.6"
id("io.spring.dependency-management") version "1.1.7"
id("org.owasp.dependencycheck") version "12.2.1"
id("org.owasp.dependencycheck") version "12.2.2"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
kotlin("jvm") version "2.3.21"
kotlin("plugin.spring") version "2.3.21"
id("org.sonarqube") version "7.2.3.7755"
id("org.sonarqube") version "7.3.0.8198"
}

group = "hu.bme.sch"
Expand Down Expand Up @@ -52,7 +52,7 @@ dependencies {
implementation("tools.jackson.dataformat:jackson-dataformat-csv")
implementation("tools.jackson.module:jackson-module-kotlin")
implementation("com.github.spullara.mustache.java:compiler:0.9.14")
implementation("com.google.auth:google-auth-library-oauth2-http:1.46.0")
implementation("com.google.auth:google-auth-library-oauth2-http:1.47.0")
implementation("com.google.zxing:core:3.5.4")
implementation("com.google.zxing:javase:3.5.4")
implementation("com.itextpdf:itext-core:9.6.0")
Expand All @@ -61,7 +61,7 @@ dependencies {
runtimeOnly("io.jsonwebtoken:jjwt-impl")
runtimeOnly("io.jsonwebtoken:jjwt-jackson")
implementation("io.jsonwebtoken:jjwt-api")
implementation(platform("io.micrometer:micrometer-bom:1.16."))
implementation(platform("io.micrometer:micrometer-bom:1.16.5"))
runtimeOnly("io.micrometer:micrometer-core")
runtimeOnly("io.micrometer:micrometer-observation")
runtimeOnly("io.micrometer:micrometer-registry-prometheus")
Expand All @@ -74,7 +74,7 @@ dependencies {
implementation("org.jetbrains.kotlin:kotlin-scripting-jvm")
implementation("org.jetbrains.kotlin:kotlin-scripting-jvm-host")
implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk8")
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2")
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.11.0")
implementation("org.springdoc:springdoc-openapi-starter-webmvc-ui:3.0.3")
implementation("org.springframework.boot:spring-boot-starter-actuator")
implementation("org.springframework.boot:spring-boot-starter-data-jpa")
Expand All @@ -85,7 +85,7 @@ dependencies {
implementation("org.springframework.boot:spring-boot-starter-web")
implementation("org.springframework.boot:spring-boot-starter-webclient")
implementation("org.springframework.session:spring-session-jdbc")
implementation("software.amazon.awssdk:s3:2.42.40")
implementation("software.amazon.awssdk:s3:2.44.12")
runtimeOnly("com.h2database:h2")
runtimeOnly("org.postgresql:postgresql")
testImplementation("org.springframework.boot:spring-boot-starter-test")
Expand Down
Binary file modified backend/gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
4 changes: 3 additions & 1 deletion backend/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.1-bin.zip
networkTimeout=10000
retries=0
retryBackOffMs=500
Comment on lines +5 to +6
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Reconsider disabling network retries entirely.

Setting retries=0 disables all retry attempts when downloading the Gradle distribution. This makes the build fragile and will cause immediate failures on temporary network issues (common in CI/CD environments or on unreliable networks).

The retryBackOffMs=500 setting becomes meaningless with zero retries.

Consider enabling a reasonable retry count to improve build resilience:

🔄 Recommended configuration
-retries=0
-retryBackOffMs=500
+retries=3
+retryBackOffMs=1000
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
retries=0
retryBackOffMs=500
retries=3
retryBackOffMs=1000
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@backend/gradle/wrapper/gradle-wrapper.properties` around lines 5 - 6, The
gradle-wrapper.properties currently sets retries=0 which disables all download
retries and makes builds fragile; update the configuration to a reasonable retry
count (e.g., set retries to 2 or 3) and keep or increase retryBackOffMs (e.g.,
2000) so the Gradle wrapper will retry transient network failures; modify the
properties for keys "retries" and "retryBackOffMs" accordingly to improve
resilience.

validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
2 changes: 1 addition & 1 deletion backend/gradlew

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 10 additions & 21 deletions backend/gradlew.bat

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions frontend/.npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
min-release-age=1
Loading
Loading