fix: Fix double injection of trust-bundle CA volumes in reconcile loop - #9260
Merged
Merged
Conversation
…p, leave it on SinkBinding webhook
knative-prow
Bot
added
the
do-not-merge/hold
knative-prow
Bot
added
size/L
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9260 +/- ##
==========================================
+ Coverage 51.04% 51.07% +0.02%
==========================================
Files 411 411
Lines 22142 22120 -22
==========================================
- Hits 11303 11298 -5
+ Misses 9962 9947 -15
+ Partials 877 875 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
creydr
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/unhold |
knative-prow
Bot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix double injection of trust-bundle CA volumes in reconcile loop, leave it on SinkBinding webhook
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs
Should stabilize flakes like: #9258
For all CI tests
/hold