Skip to content

Add extraObjects support to the knative-operator chart - #2342

Open
aqeelat wants to merge 1 commit into
knative:mainfrom
aqeelat:chart-extra-objects
Open

Add extraObjects support to the knative-operator chart#2342
aqeelat wants to merge 1 commit into
knative:mainfrom
aqeelat:chart-extra-objects

Conversation

@aqeelat

@aqeelat aqeelat commented Aug 19, 2026

Copy link
Copy Markdown

What

Adds an optional extraObjects list to the knative-operator Helm chart. Each entry renders as a manifest alongside the operator. Empty by default — no behavior change for existing installs.

Why

Operators frequently need small platform-specific adjuncts that don't belong in the chart proper: OpenShift SCC bindings, extra RBAC, NetworkPolicies, PriorityClasses. The standard Helm extraObjects idiom (as in kube-prometheus-stack and bitnami charts) lets users keep those in the same release instead of parallel tooling.

Example:

extraObjects:
  - apiVersion: rbac.authorization.k8s.io/v1
    kind: ClusterRoleBinding
    metadata:
      name: knative-serving-nonroot-v2-scc
    roleRef:
      apiGroup: rbac.authorization.k8s.io
      kind: ClusterRole
      name: system:openshift:scc:nonroot-v2
    subjects:
      - kind: ServiceAccount
        name: default
        namespace: knative-serving

cc @dsimansk @kahirokunn

Signed-off-by: Abdullah Alaqeel <abdullah.t.aqeel@gmail.com>
@knative-prow

knative-prow Bot commented Aug 19, 2026

Copy link
Copy Markdown

Welcome @aqeelat! It looks like this is your first PR to knative/operator 🎉

@knative-prow
knative-prow Bot requested review from aliok and kahirokunn August 19, 2026 22:23
@knative-prow knative-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2026
@knative-prow

knative-prow Bot commented Aug 19, 2026

Copy link
Copy Markdown

Hi @aqeelat. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow

knative-prow Bot commented Aug 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aqeelat
Once this PR has been reviewed and has the lgtm label, please assign aliok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant