All parsers: anchor is_test_file to path components#108
Open
gadievron wants to merge 1 commit into
Open
Conversation
…tring (BUG-NEW 2,22) Local-only finder-fixes-54. 3 parametrized tests across 5 langs. is_test_file used unanchored 'pattern in path_lower' (zig worst: bare test/spec tokens), so real source whose name CONTAINS a token (latest/contest/attestation/inspector) was silently dropped from extraction (skip_tests=True is the pipeline default). Anchored to exact path DIRECTORY components + basename conventions across c/php/python/ruby/zig repository_scanner. JS/Go already anchored -> untouched (judge-confirmed). Decoys not excluded; real test files still excluded (recall preserved). Judge: AGREE / SHIP-AS-IS. Local-only; not pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit d8c5f3fb0387c969a7e7c899a8d59e598c46a477)
Collaborator
Author
|
Merge-order note (not a defect — flagging for landing order) This consolidated
This is the most error-prone overlap in the set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All parsers: anchor is_test_file to path components
Local-only branch
pr/is-test-file-anchoringoff master368b559. One of a coordinated 7-PR set fixing parser/reachability bugs found by the OpenAnt finder. File-disjoint from the other 6 PRs (no merge collision; any order).Addresses 2 finder bug-ids (2 distinct fixes; 0 ride a same-PR canonical).
Bugs fixed
[2]is-test-file-substring (multi/path_substring_exclusion) — genuinely-new (no prior logged entry)[22]zig-path_substring_exclusion-repository_scanner-118 (zig/path_substring_exclusion) — genuinely-new (no prior logged entry)Dedup status (independent + judge, from raw)
2 genuinely-new · 0 duplicate-of-curated (cross-ref above) · 0 covered-by-curated · 0 intra-PR-duplicate. All re-confirmed STILL PRESENT on pristine master
368b559(git show 368b559:).Tests
Verified GREEN in isolation off pristine
368b559: 24 passed (test_repository_scanner_is_test_file_cma). New per-bug regression tests. (Notest_<lang>_schema_completeness.py/test_callgraph_symmetry.pyparser-infra in this PR — a follow-up; master has none either.)Notes
🤖 Generated with Claude Code