Ruby parser: fix 11 finder bugs#113
Open
gadievron wants to merge 3 commits into
Open
Conversation
…/builtin/method-object/substring-import (BUG-NEW 1,8,11,31,49) Local-only finder-fixes-54 (base master 368b559). TDD; 10 tests in the new tests/parsers/ruby/test_call_graph_builder_u*.py. Judge (vs prepared recommendation, independent re-derivation from raw): AGREE / SHIP-AS-IS. CM-B builtin pre-check scoped SAME-FILE (judge-confirmed: no global cross-file fallback; genuine-builtin non-link pinned by a negative test). Combined parser suite: 70 passed, 10 skipped. Local-only; not pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit 74153f98a94f9e8b95c39083d3d0eaf71ea7956e)
…ethod/alias/private/nested-class (BUG-NEW 6,18,24,42,44,50) Local-only finder-fixes-54. 8 tests. recurse method bodies; is_singleton before initialize; define_method(:sym) registers sym [24] and alias node registers name [42] (DISTINCT AST nodes, judge-confirmed); private/ public/protected keyword-state visibility model [44]; compose Outer::Inner [50]. Judge: AGREE / SHIP-AS-IS. Local-only; not pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit 825c92d71c686234828215102da60eb584e0de7b)
…ding (BUG-NEW 31) Ruby hunk of the alias-guard (python hunk ships in the python PR). Local-only; not pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gadievron
requested review from
ar7casper,
dgeyshis,
shahar-davidson,
sounil and
yotamleo
as code owners
Collaborator
Author
|
Merge-order note (not a defect — flagging for landing order)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby parser: fix 11 finder bugs
Local-only branch
pr/ruby-parseroff master368b559. One of a coordinated 7-PR set fixing parser/reachability bugs found by the OpenAnt finder. File-disjoint from the other 6 PRs (no merge collision; any order).Addresses 11 finder bug-ids (11 distinct fixes; 0 ride a same-PR canonical).
Bugs fixed
[1]ruby-parenless-call (ruby/masking_floor) — genuinely-new (no prior logged entry)[6]rb-nested-extraction (ruby/extraction_gap) — genuinely-new (no prior logged entry)[8]rb-crossfile-class-overresolve (ruby/wrong_edge) — genuinely-new (no prior logged entry)[11]rb-builtin-render (ruby/masking_floor) — genuinely-new (no prior logged entry)[18]ruby-metadata-134-singleton (ruby/metadata_correctness) — genuinely-new (no prior logged entry)[24]ruby-extraction_gap-304-definemethod (ruby/extraction_gap) — Fixes BUG-089 (previously logged; was fixed only on an unmerged branch, still live on master 368b559)[31]ruby-dataflow_loss-228-methodobj (ruby/dataflow_loss) — genuinely-new (no prior logged entry)[42]ruby-extraction_gap-304-alias (ruby/extraction_gap) — Fixes BUG-094 (previously logged; was fixed only on an unmerged branch, still live on master 368b559)[44]ruby-unit_metadata-153-private (ruby/unit_metadata_correctness) — genuinely-new (no prior logged entry)[49]ruby-substring_import_overmatch-252 (ruby/substring_import_overmatch) — genuinely-new (no prior logged entry)[50]ruby-metadata-278-nestedclass (ruby/metadata_correctness) — genuinely-new (no prior logged entry)Dedup status (independent + judge, from raw)
9 genuinely-new · 2 duplicate-of-curated (cross-ref above) · 0 covered-by-curated · 0 intra-PR-duplicate. All re-confirmed STILL PRESENT on pristine master
368b559(git show 368b559:).Tests
Verified GREEN in isolation off pristine
368b559: 20 passed (tests/parsers/ruby/). New per-bug regression tests. (Notest_<lang>_schema_completeness.py/test_callgraph_symmetry.pyparser-infra in this PR — a follow-up; master has none either.)Notes
🤖 Generated with Claude Code