fix(cli): add zig to the --language choices for parse and scan#119
Open
gadievron wants to merge 1 commit into
Open
fix(cli): add zig to the --language choices for parse and scan#119gadievron wants to merge 1 commit into
gadievron wants to merge 1 commit into
Conversation
The zig parser is dispatched by parse_repository (core/parser_adapter.py:126) and has a working test_pipeline, but 'zig' was missing from the parse/scan --language choices, so 'openant parse --language zig' errored with 'invalid choice'. Pre-existing gap (present on master); surfaced while verifying the library-mode work — zig library-mode is unreachable via the CLI without this. Verified: 'openant parse /tmp/zig-kf --language zig --level reachable --library-mode' now runs (9 -> 21 reachable functions under library-mode).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cli): add zig to the
--languagechoices for parse and scanProblem
openant parse --language zig(andscan) fails withargument --language/-l: invalid choice: 'zig'. The Zig parser is fully wired everywhere else:core/parser_adapter.parse_repositorydispatcheslanguage == "zig",detect_language()returns"zig"and lists it in its docstring + the "no source files" error, andconfig/languages.jsonmaps.zig→zig. Only the explicit--languageargparsechoiceslist inopenant/cli.py(for bothparseandscan) was never updated — so Zig was reachable via--language autobut not by explicit selection.Fix
Add
"zig"to thechoiceslist at bothcli.pysites (parse + scan). Purely additive; exposes nothing new —autoalready routed.zigrepos to the Zig parser.Verification
Not a security fix
CLI usability fix.
Tests
No test pins the
--languagechoices list (verified:grep -rn 'choices=\[.auto' tests/= 0). The change is a 2-line argparse addition.Depends-on
None (standalone; the choices list is pre-existing on master).