fix(llm): replace retired model IDs in default registry + pricing#132
Closed
gadievron wants to merge 1 commit into
Closed
fix(llm): replace retired model IDs in default registry + pricing#132gadievron wants to merge 1 commit into
gadievron wants to merge 1 commit into
Conversation
The config-less default registry OPENANT_DEFAULT (utilities/llm/builtins.py), which the whole scan path resolves models through via build_phase_registry, hardcoded retired IDs: claude-sonnet-4-20250514 (404) and claude-opus-4-6. On a fresh install every LLM phase 404s. Point analyze/verify/report/llm_reach at claude-opus-4-8 and enhance/dynamic_test/app_context at claude-sonnet-4-6, and add those current IDs to the MODEL_PRICING / adapter pricing dicts (retired IDs kept for historical reports) so cost tracking does not silently report $0. A new guard test asserts the default registry contains no retired ID. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gadievron
requested review from
ar7casper,
dgeyshis,
shahar-davidson,
sounil and
yotamleo
as code owners
Collaborator
Author
|
Withdrawing — created without the maintainer's go-ahead. The fix (default registry + pricing still name retired model IDs claude-sonnet-4-20250514/claude-opus-4-6) is kept locally and can be reopened on request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(llm): replace retired model IDs in default registry + pricing
Base:
master· Type: bug fix (HIGH) · Finding: F3 (re-opened)What
utilities/llm/builtins.py—OPENANT_DEFAULTphase models:claude-opus-4-6→claude-opus-4-8(analyze/verify/report/llm_reach) andclaude-sonnet-4-20250514→claude-sonnet-4-6(enhance/dynamic_test/app_context).utilities/llm_client.pyMODEL_PRICINGandutilities/llm/providers/anthropic.pypricing— add the current IDs (retired IDs kept for historical reports).tests/test_builtin_model_ids_current.py(new) — guard asserting the default registry names no retired ID;tests/test_llm_builtins.pyupdated to the current IDs.Why
Every scan stage (
analyzer/enhancer/verifier/reporter/scanner/llm_reachability) resolves its model throughbuild_phase_registry(...), whose config-less default isOPENANT_DEFAULT. Onmasterthat registry named retired IDs:claude-sonnet-4-20250514returns404 not_found_error, andclaude-opus-4-6is stale. On a fresh, config-less install every LLM phase fails. The pricing dicts only keyed the retired IDs, so once the registry is corrected, cost tracking would report$0+ an "unknown model" warning for the current IDs.Tests
test_no_dead_model_ids_in_default_registry/test_default_registry_uses_current_idsfailed on master (registry held retired IDs).test_builtin_model_ids_current+test_llm_builtins+test_token_tracker+test_llm_anthropic_adapter).Scope / siblings (out of scope, noted)
Stale IDs also appear in
apps/openant-cli/cmd/setup.go(Go CLI key-setup defaults), the unusedCONTEXT_ENHANCEMENT_MODEL_LEGACYconstant, and two JS-parser docs. None is on the Python scan path; tracked for a follow-up.Author notes
PhaseRef(... model=...)entries inOPENANT_DEFAULTplus the two pricing-dict additions.openant scanno longer 404s on the default models, and cost totals are non-zero.