Harden GitHub Actions workflows against token disclosure#1
Merged
Conversation
- Pin every action to a commit SHA (with version comment) - Top-level permissions: contents: read on both workflows - persist-credentials: false on every actions/checkout - Switch pint to --test mode; drop git-auto-commit-action dependency - Add .github/dependabot.yml (monthly, grouped, labelled) - Add .github/CODEOWNERS so future .github/ changes need review Same pattern as knotsphp/publicip#6.
2 tasks
SRWieZ
added a commit
that referenced
this pull request
May 18, 2026
The Linting workflow was switched from auto-fix mode to --test in #1, which surfaces pre-existing style issues that the old workflow silently fixed and force-committed. Replace fully-qualified class references with imports in cli/flushdns.php and tests/Unit/ArchTest.php so pint passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens CI in response to Composer CVE-2026-45793. Same pattern as knotsphp/publicip#6.
permissions: contents: readon both workflowspersist-credentials: falseon everyactions/checkout--testmode; dropgit-auto-commit-actiondependency.github/dependabot.yml(monthly, grouped, labelled).github/CODEOWNERS