feat: Add servo motor inertia ratio calculations#1
Conversation
- Added `calculate_inertia_ratio` to `library/mechatronics.py` - Added `_calculate_acceleration_torque` as a private method to reuse existing logic - Added tests to `tests/test_gear_electrical_mechatronics.py` using provided example values - Updated logic to enforce keyword-only arguments per codebase conventions Co-authored-by: evangress <106449014+evangress@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR integrates a new set of servo motor calculations into the existing
Mechatronicsclass.Key changes:
calculate_inertia_ratio: Added to compute total load inertia and inertia ratio using reflected inertia and ballscrew/timing-belt dynamics._calculate_acceleration_torque: Added as a private method to use linear acceleration and mechanical reduction ratios to compute required acceleration torque using the baseacceleration_torquemethod.tests/test_gear_electrical_mechatronics.pyto ensure accuracy based on provided example usage parameters.PR created automatically by Jules for task 15092538530164795809 started by @evangress