Conversation
- HttpHeader를 struct에서 enum(StrKey, StringKey)으로 전환하여 유연성 확보 - HttpResponse의 HashMap 기반 헤더 관리를 성능 최적화된 HttpResponseHeader로 대체 - set_header 시 참조 대신 소유권을 넘기도록 변경하여 불필요한 복사 방지
- cleanup unused functions - ToString to ToStr and return &str - refactoring response the response header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpHeader를 enum으로 변경하고 HttpResponseHeader를 통해 헤더 관리 방식을 개선했습니다.
주요 변경 사항: