Skip to content

used self.port in bind, instead of the hardcoded 0 - #2682

Closed
yliaog wants to merge 1 commit into
kubernetes-client:masterfrom
yliaog:master
Closed

used self.port in bind, instead of the hardcoded 0#2682
yliaog wants to merge 1 commit into
kubernetes-client:masterfrom
yliaog:master

Conversation

@yliaog

@yliaog yliaog commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Aug 14, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from fabianvf and roycaihw August 14, 2026 18:17
@kubernetes-prow kubernetes-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2026
@yliaog

yliaog commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

self = <DummyProxy(Thread-51, initial daemon)>, host = '127.0.0.1', port = 8888

def __init__(self, host='127.0.0.1', port=8888):
    super().__init__(daemon=True)
    self.host = host
    self.port = port
    self.received_connect = False
    self._server_sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
    self._server_sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
  self._server_sock.bind((self.host, self.port))

E OSError: [Errno 98] Address already in use

@yliaog

yliaog commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

ok, should keep using port 0 to avoid "E OSError: [Errno 98] Address already in use"

@yliaog

yliaog commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

/close

@kubernetes-prow kubernetes-prow Bot closed this Aug 14, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

@yliaog: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant