feat(cinder-csi-plugin): add splitMode by cwrau · Pull Request #3067 · kubernetes/cloud-provider-openstack

cwrau · 2026-01-23T16:49:06Z

What this PR does / why we need it:

This allows the user to deploy the controller-manager split between the
management cluster and the workload cluster.

That way one can keep all openstack credentials out of the workload cluster.

Release note:

[cinder-csi-controller-manager] Allow deploying the controller-manager split between management and workload clusters.

k8s-ci-robot · 2026-01-23T16:49:13Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2026-01-23T16:49:16Z

Hi @cwrau. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

cwrau · 2026-02-16T18:04:25Z

Hello, anything I can do to help this getting reviewed?

cwrau · 2026-03-20T08:35:14Z

Hello, is there something I can do to get this merged?

k8s-triage-robot · 2026-07-20T20:14:48Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

cwrau · 2026-07-20T20:15:52Z

Still waiting for review...

kayrus · 2026-07-23T13:09:28Z

/ok-to-test

234u34k

Blocking default-values regression; reproduction and requested test are documented inline.

234u34k

Confirmed on c52e1c93. The hostMount path is restored in both templates and the checks pass. This addresses my requested change, thank you

stephenfin · 2026-09-10T22:04:48Z

/assign @stephenfin

chenwng · 2026-09-11T11:59:33Z

I think it would be great to describe this feature and its use case in docs/cinder-csi-plugin/using-cinder-csi-plugin.md

kayrus · 2026-09-14T13:13:44Z

relates to #2655

kayrus · 2026-09-14T13:22:03Z

/remove-lifecycle stale

kayrus · 2026-09-14T13:22:07Z

/lgtm

mandre · 2026-09-15T06:52:41Z

            path: /etc/config
        {{- end }}
-        {{- with .Values.csi.plugin.volumes }}
+        {{- with .Values.splitMode.enabled | ternary .Values.splitMode.volumes .Values.csi.plugin.volumes }}


The ternary makes it that splitMode completely ignores .Values.csi.plugin.volumes in favor of .Values.splitMode.volumes. That might be confusing. Consider merging rather than replacing.

That won't work sadly, as one cannot remove an entry from the volumes and with the splitMode you don't want the /etc/cacert

kubernetes-prow · 2026-09-15T07:46:27Z

New changes are detected. LGTM label has been removed.

kubernetes-prow · 2026-09-15T07:46:33Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kayrus. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This allows the user to deploy the controller-manager split between the management cluster and the workload cluster.

Signed-off-by: Chris Werner Rau <cwrau@cwrau.info>

cwrau · 2026-09-25T14:32:55Z

My rebase off of master cleared the lgtm, @kayrus, could you review again please? 🙏

k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 23, 2026

k8s-ci-robot requested review from kayrus and stephenfin January 23, 2026 16:49

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 23, 2026

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 23, 2026

cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch from aaeb1a0 to 81a7702 Compare January 23, 2026 16:50

cwrau mentioned this pull request Jan 23, 2026

feat(openstack-cloud-controller-manager): add splitMode #3063

Open

cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch from 81a7702 to 708e56f Compare April 21, 2026 19:24

kubernetes-prow Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 20, 2026

cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch from 708e56f to 0e667c6 Compare July 21, 2026 08:05

kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2026

234u34k suggested changes Jul 25, 2026

View reviewed changes

Comment thread charts/cinder-csi-plugin/templates/controllerplugin-deployment.yaml Outdated

cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch from 0e667c6 to c52e1c9 Compare July 27, 2026 12:46

234u34k approved these changes Jul 28, 2026

View reviewed changes

cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch from c52e1c9 to 89904d7 Compare August 5, 2026 08:12

cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch 2 times, most recently from 3ab8cd8 to c4d52e4 Compare September 10, 2026 20:29

kubernetes-prow Bot assigned stephenfin Sep 10, 2026

cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch from c4d52e4 to fc2656c Compare September 13, 2026 17:53

cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch from fc2656c to 53f1f29 Compare September 13, 2026 17:54

kubernetes-prow Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 14, 2026

kubernetes-prow Bot assigned kayrus Sep 14, 2026

kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2026

mandre reviewed Sep 15, 2026

View reviewed changes

cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch from 53f1f29 to e15e433 Compare September 15, 2026 07:46

kubernetes-prow Bot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2026

mandre reviewed Sep 15, 2026

View reviewed changes

Comment thread charts/cinder-csi-plugin/templates/nodeplugin-daemonset.yaml Outdated

cwrau added 2 commits September 15, 2026 11:03

feat(cinder-csi-plugin): add splitMode

59d0359

This allows the user to deploy the controller-manager split between the management cluster and the workload cluster.

chore: add ci test files

bfd7a90

Signed-off-by: Chris Werner Rau <cwrau@cwrau.info>

cwrau force-pushed the feat/cinder-csi-plugin/add-split-mode branch from e15e433 to bfd7a90 Compare September 15, 2026 09:03

Conversation

cwrau commented Jan 23, 2026

Uh oh!

k8s-ci-robot commented Jan 23, 2026

Uh oh!

k8s-ci-robot commented Jan 23, 2026

Uh oh!

cwrau commented Feb 16, 2026

Uh oh!

cwrau commented Mar 20, 2026

Uh oh!

k8s-triage-robot commented Jul 20, 2026

Uh oh!

cwrau commented Jul 20, 2026

Uh oh!

kayrus commented Jul 23, 2026

Uh oh!

234u34k left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

234u34k left a comment

Choose a reason for hiding this comment

Uh oh!

stephenfin commented Sep 10, 2026

Uh oh!

chenwng commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kayrus commented Sep 14, 2026

Uh oh!

kayrus commented Sep 14, 2026

Uh oh!

kayrus commented Sep 14, 2026

Uh oh!

Uh oh!

Uh oh!

mandre Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

cwrau Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

kubernetes-prow Bot commented Sep 15, 2026

Uh oh!

kubernetes-prow Bot commented Sep 15, 2026

Uh oh!

Uh oh!

cwrau commented Sep 25, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

chenwng commented Sep 11, 2026 •

edited

Loading