Conversation
Implement CSI ControllerModifyVolume for NFS shares so VolumeAttributesClass updates reconcile Manila IP access rules. Preserve non-rw rules, wait for asynchronous grant and revoke operations, and document the required RBAC and usage.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @taaahaaa! |
|
Hi @taaahaaa. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Provide ControllerModifyVolume secrets and an NFS share client parameter now that the driver advertises MODIFY_VOLUME.
|
All required checks are passing, and this is ready for review. @gouthampacha @kayrus, could you please take a look when you have time? |
What this PR does / why we need it:
Adds support for updating Manila NFS share access rules after a PVC has been provisioned. The Manila CSI plugin now advertises the CSI
MODIFY_VOLUMEcontroller capability for NFS and implementsControllerModifyVolumeso changes tonfs-shareClientthrough aVolumeAttributesClassreconcile the share'srwIP access rules.The reconciliation is idempotent, grants and activates new rules before removing obsolete rules, waits for revocations to complete, and preserves read-only and non-IP rules. Mutable parameters are also honored during initial volume creation.
The Helm RBAC grants access to
VolumeAttributesClassresources, and the Manila CSI documentation includes an example.Which issue this PR fixes(if applicable):
Fixes #3226
Special notes for reviewers:
Validated with:
go test ./pkg/csi/...go vet ./pkg/csi/manila/...helm lint charts/manila-csi-plugingit diff --checkRelease note: