Skip to content

[manila-csi-plugin] Support mutable NFS access rules - #3227

Open
taaahaaa wants to merge 2 commits into
kubernetes:masterfrom
taaahaaa:manila-dynamic-access-rules
Open

taaahaaa wants to merge 2 commits into
kubernetes:masterfrom
taaahaaa:manila-dynamic-access-rules

Conversation

@taaahaaa

Copy link
Copy Markdown

What this PR does / why we need it:

Adds support for updating Manila NFS share access rules after a PVC has been provisioned. The Manila CSI plugin now advertises the CSI MODIFY_VOLUME controller capability for NFS and implements ControllerModifyVolume so changes to nfs-shareClient through a VolumeAttributesClass reconcile the share's rw IP access rules.

The reconciliation is idempotent, grants and activates new rules before removing obsolete rules, waits for revocations to complete, and preserves read-only and non-IP rules. Mutable parameters are also honored during initial volume creation.

The Helm RBAC grants access to VolumeAttributesClass resources, and the Manila CSI documentation includes an example.

Which issue this PR fixes(if applicable):

Fixes #3226

Special notes for reviewers:

Validated with:

  • go test ./pkg/csi/...
  • go vet ./pkg/csi/manila/...
  • helm lint charts/manila-csi-plugin
  • git diff --check

Release note:

[manila-csi-plugin] Support updating NFS share client access rules through VolumeAttributesClass.

Implement CSI ControllerModifyVolume for NFS shares so VolumeAttributesClass updates reconcile Manila IP access rules. Preserve non-rw rules, wait for asynchronous grant and revoke operations, and document the required RBAC and usage.
@kubernetes-prow kubernetes-prow Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 15, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mandre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 15, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @taaahaaa!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 15, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @taaahaaa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 15, 2026
@gouthampacha

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 15, 2026
Provide ControllerModifyVolume secrets and an NFS share client parameter now that the driver advertises MODIFY_VOLUME.
@taaahaaa

Copy link
Copy Markdown
Author

All required checks are passing, and this is ready for review. @gouthampacha @kayrus, could you please take a look when you have time?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[manila-csi-plugin] Support mutable NFS access rules

2 participants