Syncs the instance settings cache when settings are updated#2189
Open
seb-kw wants to merge 1 commit into
Open
Conversation
…tale response is avoided Signed-off-by: Sebastian Kawelke <sebastian.kawelke@l3montree.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ConfigService.SetJSONConfig to keep the in-memory instanceSettings cache aligned with configuration updates written to the database, reducing the window where API/middleware reads may observe stale settings.
Changes:
- Change
SetJSONConfigto return early on repository save error instead of returning the repository call directly. - Add logic to refresh the in-memory
instanceSettingscache + expiry after successfully saving theinstanceSettingsconfig.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+52
to
+58
| // Keep the in-memory instance settings cache in sync with the DB write | ||
| if key == "instanceSettings" && instanceSettingsCache != nil { | ||
| if settings, ok := v.(shared.InstanceSettings); ok { | ||
| instanceSettingsCache = &settings | ||
| instanceSettingsExpiry = time.Now().Add(5 * time.Minute) | ||
| } | ||
| } |
Comment on lines
+53
to
+55
| if key == "instanceSettings" && instanceSettingsCache != nil { | ||
| if settings, ok := v.(shared.InstanceSettings); ok { | ||
| instanceSettingsCache = &settings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.