Repository navigation
fix(tui): confirm Stop with Enter so y can never stop a session - #60
Merged
Merged
Conversation
In Flow, K armed a stop that the next y confirmed. y is also the key that allows a permission prompt, so a user who pressed K by mistake, or who was answering prompts, could stop a session while meaning "allow". K now asks "Stop "<title>"? Enter stop · any other key cancels". Only Enter confirms; y and n cancel the stop and stay prompt answers only. Claude-Session: https://claude.ai/code/session_01T2vtcW6ihn1ywy9vxUq9a4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the UI/UX review: in Flow,
Karmed a stop that the nextyconfirmed, andyis also the key that allows a permission prompt (internal/tui/board.go). A user answering prompts could stop a session while meaning "allow".Know showsStop "<title>"? Enter stop · any other key cancels; only Enter confirms.y/ncancel a pending stop and remain prompt answers only.K Stop, then Enter.TestBoardStopNeedsConfirmationchecks that bothyandncancel and only Enter stops.just checkpasses.https://claude.ai/code/session_01T2vtcW6ihn1ywy9vxUq9a4