Repository navigation
fix(app): address the desktop app code review - #66
Merged
Merged
Conversation
The collector's chat client gave up on a long poll after 10 s while the broker waits 15 s, so every quiet poll answered 404 and the chat showed Reconnecting. The client now waits past the broker's wait, and the page treats a client deadline as no change. The updates cursor now remembers the keys of the newest tail rows it covered, so a row that arrives with an older timestamp is still sent once. Claude-Session: https://claude.ai/code/session_01T2vtcW6ihn1ywy9vxUq9a4
…aunches - The collector's DRIGA_* variables are exactly the app's own, so a login shell's DRIGA_DATA_DIR or settings never point it elsewhere. - Each launch reads the login shell again in the background; the stored environment serves until the fresh one arrives. - The supervisor keeps checking with backoff that a running child serves chat, and reports collecting once it does. - A cancelled relaunch after an upgrade no longer starts the new binary's collector under the old app; the tray asks for a restart and the app asks again on its next check. - The single-instance lock is taken before the store is opened, so a second launch never opens it. Claude-Session: https://claude.ai/code/session_01T2vtcW6ihn1ywy9vxUq9a4
driga app now opens the bundle it ran from with open -a, not whichever bundle has the identifier. driga collect checks --notify-fd and --parent-fd with fstat (GetFileType on Windows) and fails at once when one is not open. Claude-Session: https://claude.ai/code/session_01T2vtcW6ihn1ywy9vxUq9a4
The Dock now shows the white Murmur on Driga's red rounded square, on Apple's 824 px grid, instead of the bare mark inside the gray tile macOS adds to plateless icons. The menu bar keeps its bare template icon. Claude-Session: https://claude.ai/code/session_01T2vtcW6ihn1ywy9vxUq9a4
The brand red is now Catppuccin Latte red (#D20F39), the same red the UI uses, in the mark, lockups, favicons, Windows icon and the macOS app icon. The menu bar shows the template icon only, with a dot while anything needs you; the count is in the tooltip and the menu. The app icon is written with PNG chunks again so every size is kept. Claude-Session: https://claude.ai/code/session_01T2vtcW6ihn1ywy9vxUq9a4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the code review of #65 (the desktop app).
DRIGA_*values from the login shell no longer reach the child; it gets exactly the app's own.driga appopens the exact bundle withopen -a <bundle>, not whichever copy Launch Services has forrun.driga.--notify-fd/--parent-fdare validated with fstat (and GetFileType on Windows), and fail fast when the fd is not open.Each fix started with a failing test. The full isolated suite, TZ=UTC runs of the touched packages,
-raceon desktop and web, andCGO_ENABLED=0vet for darwin, linux and windows all pass. A scoped review of this diff found no new Critical or Important issues.https://claude.ai/code/session_01T2vtcW6ihn1ywy9vxUq9a4