Repository navigation
fix(middleware): accept gzip bodies exactly at the size limit - #3136
Closed
Shubham-Padkonde wants to merge 1 commit into
Closed
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Member
|
Thank you @Shubham-Padkonde. Your decompression boundary correction has been incorporated with attribution into the security fixes merged in 1855061 and backported to v4 in 3fb0ba7. The tests cover exactly-at-limit bodies and persistent overflow errors. Closing this PR as incorporated; the v5.4.1 and v4.16.1 releases are being prepared. |
This was referenced Oct 27, 2026
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a gzip body has exactly
MaxDecompressedSizebytes, reading once more currently returns HTTP 413 instead of EOF. This can reject a valid body even though it stays within the configured limit.Probe for one more decompressed byte after reaching the limit. EOF remains successful, while actual excess data returns 413 and subsequent reads retain that error. Empty reads do not consume the probe.
Added regressions using real gzip streams for the exact boundary and repeated reads after exceeding it. The exact-boundary regression fails before the fix.
Validation:
go test ./... -count=1andgo vet ./...pass on Windows;go test -race ./...passes on Ubuntu.