fix(ci): install libprotobuf-dev in the Debian 12 release containers - #54
Merged
Merged
Conversation
Both debian12 build rows failed at "Configure + build" in the v0.1.5 release run, ~14 minutes in, while the ubuntu-24.04 rows succeeded: protoc failed: google/protobuf/empty.proto: File not found. encodings_v2_0.proto:8:1: Import "google/protobuf/empty.proto" was not found or had errors. protoc itself was installed correctly. What was missing were the well-known type definitions under /usr/include/google/protobuf/, which lance-encoding's build script imports. On Debian and Ubuntu those files ship in libprotobuf-dev, and protobuf-compiler only Recommends that package rather than depending on it. The ubuntu-24.04 rows run a plain `apt-get install -y protobuf-compiler`, which honors Recommends and therefore picks it up implicitly. The container step added --no-install-recommends, which silently dropped it. That flag was mine, so this is a regression introduced in lance-format#53. Isolated with a controlled comparison in real containers: debian:12 protobuf-compiler --no-install-recommends empty.proto absent, import FAILS debian:12 protobuf-compiler (recommends on) present, import OK debian:12 protobuf-compiler + libprotobuf-dev present, import OK ubuntu:24.04 protobuf-compiler present, import OK Adding libprotobuf-dev explicitly is preferred over dropping --no-install-recommends: it states the real dependency and keeps the other eleven packages from pulling in their recommends. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two failing
debian12rows in the v0.1.5 release run. Regression from #53, which was mine.What broke
Both
debian12rows died atConfigure + buildabout 14 minutes in, while theubuntu-24.04rows succeeded:protocinstalled fine. What was missing were the well-known type definitions under/usr/include/google/protobuf/, whichlance-encoding's build script imports.Root cause
On Debian and Ubuntu those
.protofiles ship inlibprotobuf-dev, andprotobuf-compileronly Recommends it rather than depending on it. Theubuntu-24.04rows run a plainapt-get install -y protobuf-compiler, which honors Recommends and picks it up implicitly. The container step I added in #53 uses--no-install-recommends, which silently dropped it.Isolated by comparing all four combinations in real containers:
empty.protoprotobuf-compiler --no-install-recommendsprotobuf-compiler(recommends on)protobuf-compiler libprotobuf-devprotobuf-compilerRow 1 reproduces the CI failure with the same two error strings. Rows 2 and 3 both resolve it.
Why this fix
Adding
libprotobuf-devexplicitly rather than dropping--no-install-recommends. It names the actual dependency, and it keeps the other eleven packages from pulling in their own recommends.Test plan
The controlled comparison above was run in real
debian:12andubuntu:24.04containers.actionlintreports no new findings (the two SC2035/SC2129 hits in the publish job predate #53).Full end-to-end proof is the release workflow itself. Worth re-dispatching
Releaseatv0.1.5once this lands, before cutting anything new.Note for #50
If #50 lands, this becomes moot for the same reason: its protoc install extracts
include/*from the upstream release zip, which is exactly the well-known types. That approach sidesteps the Recommends trap entirely and is arguably the more robust one.🤖 Generated with Claude Code