feat: support additional SQL filter pushdown for scanners - #67
Merged
Conversation
zhangstar333
force-pushed
the
test_pick
branch
2 times, most recently
from
August 28, 2026 09:09
145681c to
c8e30c5
Compare
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
K-changes
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The previous filter-schema issue is fixed. Primary SQL/Substrait and appended SQL predicates now compose through Lance’s fully configured scanner, preserving metadata and query-generated columns while ANDing every additional predicate. Coverage now exercises metadata, _distance, _score, and multiple appended predicates.
lance-gatekeeper
Bot
added
the
K-approved
jja725
approved these changes
Aug 31, 2026
jja725
left a comment
jja725
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, can you resolve the conflict?
zhangstar333
force-pushed
the
test_pick
branch
from
August 31, 2026 05:00
c737fad to
cc95d9f
Compare
lance-gatekeeper
Bot
removed
the
K-approved
Contributor
Author
@jja725 thanks, have done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AND.