Repository navigation
feat: batch generic row lookups across base and WAL - #302
Merged
Merged
Conversation
beinan
marked this pull request as ready for review
October 4, 2026 04:04
beinan
marked this pull request as draft
October 4, 2026 04:31
beinan
marked this pull request as ready for review
October 4, 2026 04:47
beinan
force-pushed
the
codex/batch-get
branch
from
October 4, 2026 06:14
8f4184d to
d9914d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
GenericStore::get_many, the shared Rust trait/facade/client API, andPOST /api/v1/generic/{name}/get-rows. Read up to 1,024 IDs together or project onlyidfor deduplication; missing IDs are omitted and repeated IDs returned once in first-requested order.Lance 9 serializes disk lookups for bare PK-IN queries. A documented zero-offset compatibility adapter selects its general indexed LSM scan, retaining flushed-WAL/newest-key semantics. Reads reuse merge-consistency retries and avoid source-local limits that could underfill results. A known Lance 9 WAL membership-index error retries native point lookups against the same captured view after discarding partial results. That compatibility path is slower; other errors still propagate. No dependencies are added or upgraded. Remove unused
lance-graphandlancedbdependencies from core; the former pulled a second Lance/DataFusion stack, legacy TLS/JWT dependencies, and Thrift into consumers of the batch API.Validation: 22 core and 10 HTTP route tests pass, including a live Rust-client round trip, a single-index-plan regression, WAL overwrites, base deletions, projections, and concurrent merges. Clippy passes for all affected crates/targets.
Local ARM64 debug benchmarks, five warm samples, 512 IDs:
Every response matched expected rows. These are local warm-cache query measurements, not Blob or ingestion throughput. The PR includes a reproducible synthetic benchmark and methodology/results in
docs/benchmarks/batch-get.md; private data is not included.