fix: render frontend content with safe DOM APIs - #91
Merged
Conversation
Collaborator
Author
|
The failed check is unrelated to this change. LanceDB 0.3.1, 0.3.4, and 0.5 have disappeared from PyPI, so the existing matrix can no longer install its legacy entries. The first failure cancelled the remaining jobs and skipped the build gate. Tracked separately in #92 with the workflow run and a recovery approach. |
Collaborator
Author
Collaborator
Author
|
Resolved: #93 is now on main, this branch has been updated, and the replacement CI run passes all 16 jobs (eight test variants and eight multi-architecture image builds). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32
Summary
innerHTMLassignments withreplaceChildren,textContent, and explicit DOM constructioninnerHTMLassignments in the frontendTesting
node --check web/vanilla/app.js../testing/run-tests.sh 0.36.0— 65 passed/healthz,/, and the packaged/app.js