Repository navigation
feat(spec): expose vector index build params on CreateTableIndexRequest - #361
Merged
Merged
Conversation
CreateTableIndexRequest exposed only index_type and distance_type alongside the FTS parameters, so namespace clients had no way to pass vector index tuning options when creating an index. The REST server already accepts all of these as flat top-level body fields, so this closes a client-side gap rather than adding new server behavior. Adds num_partitions, num_sub_vectors, num_bits, sample_rate, max_iterations, target_partition_size, m and ef_construction as optional integers, matching the server's parameter set exactly so the spec does not fall behind again for the remaining knobs. Also refreshes docs/src/namespace/operations/models/AddColumnsEntry.md, which went stale when #360 regenerated the clients without running make build-docs. No CI job covers the copied model docs.
github-actions
Bot
added
enhancement
brendanclement
marked this pull request as ready for review
August 17, 2026 21:48
jackye1995
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the vector index build parameters to CreateTableIndexRequest. As of today, CreateTableIndexRequest only exposed index_type and distance_type, so a client creating a vector index could not pass any tuning options. Users who need a specific IVF partition count have no way to express it.
Drive by change:
docs/src/namespace/operations/models/AddColumnsEntry.mdwas rrefreshed. It went stale whena previous change regenerated the clients without running doc generation.