Repository navigation
Conversation
Expose Scanner-compatible order_by on QueryTableRequest and AnalyzeTableQueryPlanRequest, also available through ExplainTableQueryPlan. Make vector optional using the existing full_text_query schema style, without adding stricter vector constraints. Regenerate the Python, Java Apache/Async, Spring Boot, and Rust components and model documentation through the existing repository tools. Keep Java OpenAPI exports as generator output without query-specific postprocessing. Export QueryTableOrderBy from the Python core package. Add source-spec validation and model serialization regression tests using existing test runners. Follow the existing Python test-template workflow, preserve Java and Rust tests across regeneration, and correct the spec path in Python and Rust CI triggers. Validation: make build, Java Checkstyle/Spotless, and Rust test formatting passed (Python: 295 tests; Java: 17 tests; Rust: 3 tests). Clean regeneration was reproducible. Regeneration and all 281 Python client tests also passed after simplifying schema validation to use only the source specification. Existing documentation link warnings remain. Scanner execution and error mapping require downstream implementation updates. BREAKING CHANGE: The generated Rust QueryTableRequest and AnalyzeTableQueryPlanRequest vector fields are now optional, and their constructors take only k. Callers supplying a vector must assign Some(Box::new(vector)) after construction or in their struct initializer.
github-actions
Bot
added
enhancement
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose Scanner-compatible order_by on QueryTableRequest and AnalyzeTableQueryPlanRequest, also available through ExplainTableQueryPlan. Make vector optional using the existing full_text_query schema style, without adding stricter vector constraints.
Regenerate the Python, Java Apache/Async, Spring Boot, and Rust components and model documentation through the existing repository tools. Keep Java OpenAPI exports as generator output without query-specific postprocessing. Export QueryTableOrderBy from the Python core package.
Add source-spec validation and model serialization regression tests using existing test runners. Follow the existing Python test-template workflow, preserve Java and Rust tests across regeneration, and correct the spec path in Python and Rust CI triggers.
Validation: make build, Java Checkstyle/Spotless, and Rust test formatting passed (Python: 295 tests; Java: 17 tests; Rust: 3 tests). Clean regeneration was reproducible. Regeneration and all 281 Python client tests also passed after simplifying schema validation to use only the source specification. Existing documentation link warnings remain. Scanner execution and error mapping require downstream implementation updates.
BREAKING CHANGE: The generated Rust QueryTableRequest and AnalyzeTableQueryPlanRequest vector fields are now optional, and their constructors take only k. Callers supplying a vector must assign Some(Box::new(vector)) after construction or in their struct initializer.