Skip to content

fix: reenable flaky tests on test_torch_kmeans.py #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 1 commit into from
Jul 22, 2026
Merged

fix: reenable flaky tests on test_torch_kmeans.py #7849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions python/python/tests/torch_tests/test_torch_kmeans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,16 @@

torch = pytest.importorskip("torch")

from lance.torch import preferred_device # noqa: E402
from lance.torch.kmeans import KMeans # noqa: E402
from lance.vector import train_ivf_centroids_on_accelerator # noqa: E402


@pytest.mark.skip(reason="flaky")
def test_kmeans():
arr = np.array(range(128)).reshape(-1, 8).astype(np.float32)
kmeans = KMeans(4, device="cpu")
# These duplicate centroids reproduce the empty clusters that made this test
# depend on random initialization before empty-cluster recovery was fixed.
centroids = torch.from_numpy(arr[[5, 5, 13, 13]])
kmeans = KMeans(4, centroids=centroids, device="cpu")
kmeans.fit(arr)

cluster_ids = kmeans.transform(arr)
Expand All @@ -27,7 +28,6 @@ def test_kmeans():
assert len(cnts) == 4 # all cluster has data


@pytest.mark.skip(reason="TODO: async dataset hangs on github CI")
def test_torch_kmeans_accept_torch_device(tmp_path: Path):
values = pa.array(np.array(range(128)).astype(np.float32))
arr = pa.FixedSizeListArray.from_arrays(values, 8)
Expand All @@ -39,7 +39,7 @@ def test_torch_kmeans_accept_torch_device(tmp_path: Path):
"vector",
2,
metric_type="L2",
accelerator=preferred_device(),
accelerator=torch.device("cpu"),
)


Expand Down
Loading