fix: support current Codex subagent activity events - #42
Draft
yunhungo wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sub_agent_activityevents withkind: startedandagent_thread_idcollab_agent_spawn_endschema and deduplicate child thread IDsexec_commandaction are nested under the parent traceRoot cause
Codex now emits successful subagent starts as
sub_agent_activity, while the resolver only recognizedcollab_agent_spawn_end. The child rollout existed on disk but its thread ID was never collected, so it was not resolved into the parent trace.Validation
pnpm exec vitest run plugins/tracing/test/parse.test.ts plugins/tracing/test/trace.test.ts(20 passed)NODE_OPTIONS=--no-warnings pnpm test(37 passed)NODE_OPTIONS=--no-warnings pnpm lintFixes #41