Skip to content

feat(api): update API spec from langfuse/langfuse 1ea859c - #1849

Merged
wochinge merged 1 commit into
mainfrom
api-spec-bot-1ea859c-33494604967-1
Sep 1, 2026
Merged

wochinge merged 1 commit into
mainfrom
api-spec-bot-1ea859c-33494604967-1

Conversation

@langfuse-bot

@langfuse-bot langfuse-bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Collaborator

Greptile Summary

The generated API update expands LLM-as-judge prompts to ordered system, user, and assistant messages and publicly exports the new role enum.

  • Adds EvaluatorChatMessageRole with system, user, and assistant values.
  • Updates evaluator prompt documentation and message typing for multi-message prompts.
  • Preserves the generated lazy-export chain across the evaluator and top-level API packages.

Confidence Score: 4/5

The public model compatibility break should be fixed before merging so existing callers can continue omitting the default user role.

The expanded enum and export wiring are consistent, but changing role from a defaulted field to a required field makes previously valid EvaluatorChatMessage(content=...) construction fail locally.

Files Needing Attention: langfuse/api/evaluators/types/evaluator_chat_message.py

Prompt To Fix All With AI
### Issue 1
langfuse/api/evaluators/types/evaluator_chat_message.py:15
**Required role breaks existing callers**

When existing callers construct `EvaluatorChatMessage(content="...")`, making `role` required removes the previous implicit `"user"` value, causing Pydantic validation to fail before an evaluator create or update request can be sent.

```suggestion
    role: EvaluatorChatMessageRole = EvaluatorChatMessageRole.USER
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

Context used:

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

@claude review

Comment thread langfuse/api/evaluators/types/evaluator_chat_message.py

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@wochinge
wochinge enabled auto-merge (squash) September 1, 2026 10:27
@wochinge
wochinge disabled auto-merge September 1, 2026 10:27
@wochinge
wochinge merged commit 949f0c0 into main Sep 1, 2026
23 checks passed
@wochinge
wochinge deleted the api-spec-bot-1ea859c-33494604967-1 branch September 1, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants