Skip to content

feat(client)!: remove blocked_instrumentation_scopes - #1931

Merged
hassiebp merged 16 commits into
prepare-v5-releasefrom
lfe-17078-python-sdk-v5-remove-blocked_instrumentation_scopes-and
Oct 7, 2026
Merged

hassiebp merged 16 commits into
prepare-v5-releasefrom
lfe-17078-python-sdk-v5-remove-blocked_instrumentation_scopes-and

Conversation

@hassiebp

@hassiebp hassiebp commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

  • Removes the deprecated blocked_instrumentation_scopes argument from Langfuse, LangfuseResourceManager, get_client and LangfuseSpanProcessor. Use should_export_span instead:
    should_export_span=lambda span: is_default_export_span(span) and (span.instrumentation_scope is None or span.instrumentation_scope.name not in blocked)
  • create_prompt(is_active=...): the parameter was already gone, so only its leftover docstring entry is removed.
  • host / LANGFUSE_HOST keep working as before, with no warning.

Tests: the two tests that existed only for the deprecated argument are removed. The app-root test that used a blocked scope now filters the same scope via should_export_span, so the "filtered parent → child becomes app root" coverage stays. A new test pins that LANGFUSE_HOST keeps working without logging a warning.

Stack: based on prepare-v5-release; #1927, #1928 and #1930 are merged.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Refactor
  • Documentation update
  • Tooling, CI, or repo maintenance

Verification

uv run --frozen ruff check .                       # All checks passed!
uv run --frozen mypy langfuse --no-error-summary   # clean
uv run --frozen pytest -q tests/unit/test_initialization.py  # 20 passed
uv run --frozen pytest -n auto tests/unit          # 715 passed, 2 skipped

Checklist

  • I self-reviewed the diff using code_review.md.
  • I added or updated tests for behavior changes.
  • I updated docs, examples, or .env.template if needed.
  • I did not hand-edit generated files; if generated files changed, I used the upstream regeneration path.
  • I did not commit secrets or credentials.
Open in Web Open in Cursor 

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable issue was identified in the changed behavior.

Summary

The PR removes the deprecated blocked-instrumentation-scopes setting throughout client initialization and span processing, leaving should_export_span as the filtering mechanism. It also warns when a deprecated host setting determines the base URL, updates filtering tests, and removes a stale prompt-parameter description.

Reviews (1) · Last reviewed commit: "feat(client)!: remove blocked_instrument..."

cursoragent and others added 4 commits October 6, 2026 14:15
Python 3.10 reaches end of life in October 2026. Raise requires-python
to >=3.11, target py311 in ruff, drop 3.10 from the CI unit matrix, and
remove the pre-3.11 fallbacks for asyncio.create_task(context=...) and
typing.NotRequired.

Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
The OpenAI integration now always uses the v1 client shapes. Remove the
pre-1.0 method definitions and every _is_openai_v1() branch, and raise
the dev dependency floor to openai>=1.0.0.

Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
The default OTLP exporter now sends x-langfuse-ingestion-version: 4 so
servers in dual-write or preview mode process exported spans directly.
It is a no-op on events_only deployments, and additional_headers can
still override it.

Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
blocked_instrumentation_scopes was deprecated in favor of
should_export_span. Remove it from Langfuse, the resource manager and
the span processor, and drop the leftover is_active entry from the
create_prompt docstring. LANGFUSE_HOST and host keep working, but now
log a deprecation warning when they decide the base URL.

Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T14:32:40.289610Z 466808b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.

Tip: disable this comment in your organization's Code Review settings.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Comment thread langfuse/_client/client.py Outdated
cursoragent and others added 9 commits October 7, 2026 08:39
inspect.iscoroutinefunction ignores asyncio's _is_coroutine marker,
which asgiref's markcoroutinefunction sets on Python < 3.12. Accept
both so such functions keep the async wrapper and their observation
ends after the coroutine runs.

Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
…o lfe-17074-python-sdk-v5-send-x-langfuse-ingestion-version-4-by-default

Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
…on-4-by-default' into lfe-17078-python-sdk-v5-remove-blocked_instrumentation_scopes-and

Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
…0' into lfe-17080-python-sdk-v5-drop-openai-sdk-10-support

Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
…on-4-by-default' into lfe-17078-python-sdk-v5-remove-blocked_instrumentation_scopes-and

Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
…penai-sdk-10-support

Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
…o lfe-17074-python-sdk-v5-send-x-langfuse-ingestion-version-4-by-default

Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
…on-4-by-default' into lfe-17078-python-sdk-v5-remove-blocked_instrumentation_scopes-and

Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
Base automatically changed from lfe-17074-python-sdk-v5-send-x-langfuse-ingestion-version-4-by-default to prepare-v5-release October 7, 2026 09:27
cursoragent and others added 3 commits October 7, 2026 14:21
…-blocked_instrumentation_scopes-and

Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>
@hassiebp
hassiebp merged commit 049a6da into prepare-v5-release Oct 7, 2026
13 checks passed
@hassiebp
hassiebp deleted the lfe-17078-python-sdk-v5-remove-blocked_instrumentation_scopes-and branch October 7, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants