feat(client)!: remove get_dataset_run, get_dataset_runs and delete_dataset_run by hassiebp · Pull Request #1933 · langfuse/langfuse-python

hassiebp · 2026-10-06T14:28:34Z

What does this PR do?

Langfuse.get_dataset_run(), get_dataset_runs() and delete_dataset_run() call GET|DELETE /api/public/datasets/{name}/runs[/{run}], which Langfuse v4 (events_only) rejects with a 404. The v5 SDK is v4-only, so they are removed rather than rerouted. The v4 shape (cursor pagination, required from_start_time, no dataset_name) is not a drop-in for the old return types.

Migration:

read runs: langfuse.api.experiments.list(...) and langfuse.api.experiments.list_items(...)
delete a run: list its items, then langfuse.api.trace.delete_multiple(trace_ids=...)

The now-unused DatasetRunWithItems, DeleteDatasetRunResponse and PaginatedDatasetRuns imports go too. The generated client in langfuse/api is untouched; the platform regen removes those endpoints later.

Stack: 6 of 10. Base: #1932. Merge after #1932.

Type of change

Verification

uv run --frozen ruff check .                       # All checks passed!
uv run --frozen mypy langfuse --no-error-summary   # clean
uv run --frozen pytest -n auto tests/unit          # 715 passed, 2 skipped

No test referenced the removed helpers. Adding a test that they are gone would only restate the diff, so I skipped it.

Checklist

I self-reviewed the diff using code_review.md.
I added or updated tests for behavior changes.
I updated docs, examples, or .env.template if needed.
I did not hand-edit generated files; if generated files changed, I used the upstream regeneration path.
I did not commit secrets or credentials.

Confidence Score: 5/5

The PR appears safe to merge as the intended breaking change.

Summary

The PR removes three high-level dataset-run methods that target endpoints unavailable to the v5 SDK, along with their unused type imports.

_{Reviews (1) · Last reviewed commit: "feat(client)!: remove get_dataset_run, g..."}

Python 3.10 reaches end of life in October 2026. Raise requires-python to >=3.11, target py311 in ruff, drop 3.10 from the CI unit matrix, and remove the pre-3.11 fallbacks for asyncio.create_task(context=...) and typing.NotRequired. Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>

The OpenAI integration now always uses the v1 client shapes. Remove the pre-1.0 method definitions and every _is_openai_v1() branch, and raise the dev dependency floor to openai>=1.0.0. Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>

The default OTLP exporter now sends x-langfuse-ingestion-version: 4 so servers in dual-write or preview mode process exported spans directly. It is a no-op on events_only deployments, and additional_headers can still override it. Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>

blocked_instrumentation_scopes was deprecated in favor of should_export_span. Remove it from Langfuse, the resource manager and the span processor, and drop the leftover is_active entry from the create_prompt docstring. LANGFUSE_HOST and host keep working, but now log a deprecation warning when they decide the base URL. Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>

propagate_attributes(metadata=...) coerced non-string values with str(), so a boolean became "True" and a list became its Python repr. Serialize them as JSON instead, like observation metadata, and drop None values instead of sending "None". Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>

…taset_run These helpers call the dataset-run endpoints that Langfuse v4 no longer serves, so they always fail with a 404. Read experiment runs through langfuse.api.experiments.list() and list_items() instead. Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>

chatgpt-codex-connector · 2026-10-06T14:31:05Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-06T14:32:40.294088Z	`66f9842`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

github-actions · 2026-10-06T14:31:07Z

@claude review

claude

Claude Code Review

No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.

_{Tip: disable this comment in your organization's Code Review settings.}

claude

Looks good — a clean, mechanical removal with no leftover references.

Reviewed: the import block diff (three now-unused imports removed), the three deleted methods for any stray usages elsewhere in langfuse/_client/ and tests (none found), and confirmed remaining references to the removed types/methods are confined to the generated langfuse/api client, which per the PR description is left untouched pending a separate regeneration.

Extended reasoning...

Pure deletion of three public wrapper methods (get_dataset_run, get_dataset_runs, delete_dataset_run) and their three now-unused imports from langfuse/_client/client.py, with no other files touched. No security-sensitive surface (no auth/crypto/permissions logic); it is a breaking API removal but is simple, self-contained, and verified by grep to leave no dangling references outside the untouched generated API client. Decided approve based on the change's small size, mechanical nature, and absence of any findings or outstanding objections in the timeline.

Use compact separators, keep non-ASCII characters, and send None as "null", so the Python and JS SDKs emit byte-identical propagated metadata values. Co-authored-by: Hassieb Pakzad <hassiebp@users.noreply.github.com>