Repository navigation
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
get_prompt(..., fallback="")andget_prompt(..., type="chat", fallback=[])currently propagate a fetch error on a cold cache. Both are valid explicit fallbacks, but the truthiness check treats them as omitted. Check forNoneso an optional prompt can fall back to empty content during an outage.Related: #2076 normalizes chat-message types; this fixes the separate empty-fallback check.
Type of change
Verification
The two new cases fail on main with
RuntimeError: Server unavailable; the existing no-fallback case still raises. After the one-line fix, both prompt test files pass (60 tests).uv run --frozen pytest tests/unit/test_prompt.py tests/unit/test_prompt_compilation.py -q uv run --frozen ruff check . uv run --frozen ruff format --check langfuse/_client/client.py tests/unit/test_prompt.py uv run --frozen mypy langfuse --no-error-summaryChecklist
code_review.md..env.templateif needed. (No changes needed.)
The PR appears safe to merge.Summary
get_promptnow honors explicit empty fallbacks when fetching a prompt fails.Reviews (1) · Last reviewed commit: "fix(prompts): honor empty fallback promp..." · Reviewed by Greptile