Archive sbatch script - #1259
Merged
Merged
Conversation
Contributor
|
|
1 similar comment
Contributor
|
|
Contributor
|
|
Contributor
|
|
Contributor
|
|
Contributor
|
|
pagrubel
approved these changes
Sep 9, 2026
pagrubel
left a comment
pagrubel
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this works well and records the batch file as it appears when the task is run, preserving the actual run.
I corrected the README, but it has to do with my previous error.
One thing we should probably do in the future is add a test to verify this using either use_script.py or write_script.py (would add tests for using the cwl generator and a workflow that has a batch script) and verify the batch script in the archive as well as other expected files.
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This address issue #1235.