MAINT: Update packaging requirement from >=24.0 to >=26.2 in /.github/constraints - #102
Conversation
| scipy>=1.13.0 | ||
| scikit-learn>=1.5.0 | ||
| packaging>=24.0 | ||
| packaging>=26.2 |
There was a problem hiding this comment.
Hmm, we currently have this in src/gfdl/__init__.py:
packaging_version = Version(packaging.__version__)
min_packaging_version = "24.0"
if packaging_version < Version(min_packaging_version):
raise ImportError(f"{packaging_version=}, but {min_packaging_version=}")so we probably don't want to merge this without adjusting that. Does it make sense to require bleeding edge packaging? I'm not sure--maybe dependabot settings should be adjusted a bit more. Bleeding edge patches for the GitHub Actions CI addons seem fine (with the 1 week "cooldown" for supply chain security that we currently have set), but for the deps.txt file I'm less certain, and one question is who this file is really intended for. Typically one would want to have CI testing for lower and upper bounds of deps, but these >= requirements are always going to pull in the latest stable release of a given package.
That in itself has some security risk--we may want to also modify CI pip install commands to use --uploaded-prior-to and set the limit to at least 7 days old for supply chain security purposes (to avoid pulling in bleeding edge releases to CI that haven't been probed in the wild for a bit).
Of course we're a small project and maybe nobody cares, but I suspect doing the "right" thing is fairly low effort anyway.
Updates the requirements on [packaging](https://github.com/pypa/packaging) to permit the latest version. - [Release notes](https://github.com/pypa/packaging/releases) - [Changelog](https://github.com/pypa/packaging/blob/main/CHANGELOG.rst) - [Commits](pypa/packaging@24.0...26.2) --- updated-dependencies: - dependency-name: packaging dependency-version: '26.2' dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
7023b00 to
35cc49f
Compare
Updates the requirements on packaging to permit the latest version.
Release notes
Sourced from packaging's releases.
Changelog
Sourced from packaging's changelog.
... (truncated)
Commits
84a87eeBump for release4a616b6docs: a few more updates to prepare for 26.2 (#1176)9de6f44ci: use native uv integration in rtd (#1175)bc76e14chore: update changelog for 26.2 (#1161)3f00091tests: add a pickle check (#1174)48a8a06fix: make Requirements/Markers pickle-safe (#1171)823b44efix: make Tags pickle-safe (#1170)4bed32dfix: make Specifier / SpecifierSet pickle-safe (#1168)963118efix: re-export ExceptionGroup for now (#1164)66e34a8docs(specifiers): add is_unsatisfiable() usage example (#1166)