Initialize problem from interpolated tables#129
Draft
adamdempsey90 wants to merge 1 commit into
Draft
Conversation
adamdempsey90
commented
May 11, 2026
| const int nspecies = v.GetSize(0, gas::prim::density()); | ||
| for (int n = 0; n < nspecies; ++n) { | ||
| const auto id = v(0, gas::prim::density(n)).sparse_id; | ||
| const Real rho = sp.gas_rho.interpToReal(xv[2], xv[1], xv[0], id); |
Collaborator
Author
There was a problem hiding this comment.
This is the slow way. It would be nice to instead create a DataBox that uses the v(0,gas::prim::density()) memory directly and interpolate all species at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This is a way to start a simulation from either a previous simulation or from an arbitrary function of space.
To really support the latter use case, though, we should probably just link in
pybind11.Description of Changes
Checklist
// This file was created in part or in whole by generative AI