Permit multiple opac tables in single spiner table - #84
Open
pdmullen wants to merge 2 commits into
Open
Conversation
pdmullen
commented
Sep 1, 2026
pdmullen
commented
Sep 1, 2026
pdmullen
commented
Sep 1, 2026
Yurlungur
approved these changes
Sep 1, 2026
Yurlungur
left a comment
Yurlungur
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Tests failing though.
| if (status != H5_SUCCESS) { | ||
| OPAC_ERROR("photons::MeanOpacity: HDF5 error\n"); | ||
| } | ||
| MeanOpacity(const std::string &filename, const std::string &material_name) { |
Collaborator
There was a problem hiding this comment.
Do opacities have material matids? If so, it might be good to offer that as an initialization option, as it might be unique in a way names are not. Up to you of course.
Collaborator
There was a problem hiding this comment.
We want integer matids normally for both sesame and ipcress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.