Skip to content

fix(web): align legacy thread metadata columns #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lastobelus merged 6 commits into from
Aug 27, 2026
+68 −38
Merged

fix(web): align legacy thread metadata columns #99

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c482c93
fix(web): align legacy thread metadata columns
lastobelus Aug 26, 2026
4b6bb2c
fix(web): preserve sidebar icon spacing when scaled
lastobelus Aug 27, 2026
d554b9a
fix(web): keep jump hints clear of metadata icons
lastobelus Aug 27, 2026
1ed09c7
fix(web): keep jump hints in one grid row
lastobelus Aug 27, 2026
0c9b234
fix(web): size jump hints to their labels
lastobelus Aug 27, 2026
53c37c1
fix(web): reserve mobile jump actions
lastobelus Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 68 additions & 38 deletions apps/web/src/components/LegacySidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,11 +576,17 @@ export const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThr
standalone
/>
);
const threadMetaClassName = isConfirmingArchive
? "pointer-events-none opacity-0"
const threadMetaVisibilityClassName = isConfirmingArchive
? "opacity-0"
: !isThreadRunning
? "pointer-events-none transition-opacity duration-150 max-sm:pr-6 group-hover/menu-sub-item:opacity-0 group-focus-within/menu-sub-item:opacity-0"
: "pointer-events-none";
? "transition-opacity duration-150 group-hover/menu-sub-item:opacity-0 group-focus-within/menu-sub-item:opacity-0"
: "";
const threadMetaClassName = `pointer-events-none inline-flex w-full justify-end ${
jumpLabel ? "col-start-1 row-start-1 z-10" : ""
} ${threadMetaVisibilityClassName}`;
const threadMetadataGridClassName = jumpLabel
? "grid shrink-0 grid-cols-[max-content] items-center max-sm:grid-cols-[max-content_calc(1.5rem*var(--legacy-sidebar-content-zoom))]"
: "grid shrink-0 grid-cols-[repeat(2,calc(0.75rem*var(--legacy-sidebar-content-zoom)))_calc(3rem*var(--legacy-sidebar-content-zoom))] items-center gap-x-[calc(0.25rem*var(--legacy-sidebar-content-zoom))] max-sm:grid-cols-[repeat(2,calc(0.75rem*var(--legacy-sidebar-content-zoom)))_calc(3rem*var(--legacy-sidebar-content-zoom))_calc(1.5rem*var(--legacy-sidebar-content-zoom))]";
Comment thread
lastobelus marked this conversation as resolved.
const [threadRowActive, setThreadRowActive] = useState(false);
const clearConfirmingArchive = useCallback(() => {
setConfirmingArchiveThreadKey((current) => (current === threadKey ? null : current));
Expand Down Expand Up @@ -937,7 +943,7 @@ export const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThr
)}
</div>
<div className="ml-auto flex shrink-0 items-center gap-1.5">
{cleanup === null && discoveredPorts.length > 0 && (
{cleanup === null && discoveredPorts.length > 0 ? (
<Tooltip>
<TooltipTrigger
render={
Expand All @@ -956,9 +962,8 @@ export const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThr
{discoveredPorts.length > 1 ? ` (+${discoveredPorts.length - 1})` : ""}
</TooltipPopup>
</Tooltip>
)}
{props.showWorktreeIndicators ? <ThreadWorktreeIndicator thread={thread} /> : null}
{terminalStatus && (
) : null}
{terminalStatus ? (
<Tooltip>
<TooltipTrigger
render={
Expand All @@ -975,37 +980,58 @@ export const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThr
</TooltipTrigger>
<TooltipPopup side="top">{terminalStatus.label}</TooltipPopup>
</Tooltip>
)}
) : null}
{/* These fixed tracks are the scanning columns for every thread row.
Empty local/worktree cells stay mounted for ordinary timestamps,
which cannot widen the grid and push either icon sideways. A
transient jump hint replaces all three cells and uses a
content-sized track so a custom shortcut cannot paint across
visible row content or create an implicit grid row; the mobile
grid retains its trailing action track. */}
<div
className={`flex min-w-12 items-center justify-end gap-1 ${
isRemoteThread ? "max-sm:min-w-24" : "max-sm:min-w-20"
}`}
className={threadMetadataGridClassName}
data-testid={`thread-metadata-grid-${thread.id}`}
>
<span className="inline-flex size-3 shrink-0 items-center justify-center">
{showsThreadEnvironmentIcon ? (
<Tooltip>
<TooltipTrigger
render={
<span
aria-label={threadEnvironmentLabel ?? "Remote"}
className={`inline-flex shrink-0 items-center justify-center ${
isConfirmingArchive ? "invisible" : ""
}`}
data-legacy-sidebar-unscaled-content
/>
}
>
<EnvironmentIcon
kind={threadEnvironmentIconKind}
context="legacy-row"
color={environmentIconColor}
className="size-3"
/>
</TooltipTrigger>
<TooltipPopup side="top">{threadEnvironmentLabel}</TooltipPopup>
</Tooltip>
) : null}
</span>
{jumpLabel === null ? (
<>
<span
className="inline-flex h-3 w-full items-center justify-center"
data-thread-metadata-column="worktree"
>
{props.showWorktreeIndicators ? (
<ThreadWorktreeIndicator thread={thread} />
) : null}
</span>
<span
className="inline-flex h-3 w-full items-center justify-center"
data-thread-metadata-column="environment"
>
{showsThreadEnvironmentIcon ? (
<Tooltip>
<TooltipTrigger
render={
<span
aria-label={threadEnvironmentLabel ?? "Remote"}
className={`inline-flex shrink-0 items-center justify-center ${
isConfirmingArchive ? "invisible" : ""
}`}
data-legacy-sidebar-unscaled-content
/>
}
>
<EnvironmentIcon
kind={threadEnvironmentIconKind}
context="legacy-row"
color={environmentIconColor}
className="size-3"
/>
</TooltipTrigger>
<TooltipPopup side="top">{threadEnvironmentLabel}</TooltipPopup>
</Tooltip>
) : null}
</span>
</>
) : null}
{isConfirmingArchive ? (
<button
ref={handleConfirmArchiveRef}
Expand Down Expand Up @@ -1057,7 +1083,11 @@ export const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThr
</Tooltip>
)
) : null}
<span className={threadMetaClassName}>
<span
className={threadMetaClassName}
data-thread-metadata-column="timestamp"
data-thread-metadata-mode={jumpLabel ? "jump" : "timestamp"}
>
<span className="inline-flex items-center gap-1">
{jumpLabel ? (
hasActiveAnnotation && thread.annotation ? (
Expand Down