fix: make the close/reset timer tests deterministic - #394
Merged
Conversation
closeCancelsPendingTimer and resetCancelsPendingTimer slept for a fraction of the debounce window and then asserted the timer never fired. On a loaded runner that sleep can overshoot the window, and once the timer has begun firing neither close() nor reset() can recall it, so the tests failed for reasons unrelated to the behaviour they cover. Both now drive a ManualTaskExecutor instead of sleeping, asserting that the scheduled task was cancelled and that draining the queue runs nothing. Co-authored-by: Cursor <cursoragent@cursor.com>
tanderson-ld
approved these changes
Aug 21, 2026
abelonogov-ld
added a commit
that referenced
this pull request
Aug 27, 2026
🤖 I have created a release *beep* *boop* --- ## [5.15.1](5.15.0...5.15.1) (2026-08-21) ### Bug Fixes * make the close/reset timer tests deterministic ([0160533](0160533)) * make the close/reset timer tests deterministic ([#394](#394)) ([984d2e6](984d2e6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > Release Please patch bump from **5.15.0** to **5.15.1**. > > Updates `version` in `gradle.properties` and the release-please manifest, and adds a changelog entry for making close/reset timer tests deterministic. No product code changes in this PR. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 1f0af77. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closeCancelsPendingTimer and resetCancelsPendingTimer slept for a fraction of the debounce window and then asserted the timer never fired. On a loaded runner that sleep can overshoot the window, and once the timer has begun firing neither close() nor reset() can recall it, so the tests failed for reasons unrelated to the behaviour they cover.
Both now drive a ManualTaskExecutor instead of sleeping, asserting that the scheduled task was cancelled and that draining the queue runs nothing.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.
Note
Overview
Makes
closeCancelsPendingTimerandresetCancelsPendingTimerdeterministic by driving aManualTaskExecutorinstead of sleeping a fraction of the debounce window.Those sleeps could overshoot on a loaded runner, so the timer fired before
close()/reset()could cancel it. The tests now assert the scheduled task was cancelled and that draining the queue runs nothing.Reviewed by Cursor Bugbot for commit 0160533. Bugbot is set up for automated code reviews on this repo. Configure here.