fix: Harden FDv1 data source destination and status-manager lifetimes - #603
Draft
beekld wants to merge 3 commits into
Draft
fix: Harden FDv1 data source destination and status-manager lifetimes#603beekld wants to merge 3 commits into
beekld wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The FDv1 streaming and polling sources received their destination and status manager as a raw pointer and reference. A source callback still in flight during teardown could reach those objects after the owner freed them. This is the use-after-free reported in #602.
The handoff now uses smart-pointer handles.
IDataSynchronizer::StartAsynctakes ashared_ptr<IDestination>.weak_ptrand hold the status manager as ashared_ptr. Neither can dangle.BackgroundSync, andClientImplown these objects viashared_ptr.The concrete sources already guarded their own callbacks, so the reported crash was latent rather than reachable through the public API. This change makes the lifetime safe by construction regardless of source behavior.
No public API change.
ClientImpl::DataSourceStatus()returns the same reference as before.