feat: Support System.Diagnostics.DiagnosticSource version 10.*#254
Open
bstordrup wants to merge 1 commit intolaunchdarkly:mainfrom
Open
feat: Support System.Diagnostics.DiagnosticSource version 10.*#254bstordrup wants to merge 1 commit intolaunchdarkly:mainfrom
bstordrup wants to merge 1 commit intolaunchdarkly:mainfrom
Conversation
bstordrup
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Closes #253
Describe the solution you've provided
Raised the upper version range limit on
System.Diagnostics.DiagnosticSourceto 11 instead of 10Describe alternatives you've considered
Considered to completely remove the upper limit, but decided for the upper limit raise as done in an earlier pull request (#149) to support version 9x of the same library.
Note
Low Risk
Low risk dependency-metadata change only; primary impact is allowing newer
System.Diagnostics.DiagnosticSourceversions, with potential runtime compatibility issues only if upstream breaks semantics.Overview
Updates
LaunchDarkly.ServerSdk.Telemetry.csprojto widen the allowed NuGet range forSystem.Diagnostics.DiagnosticSourceonnetstandard2.0/net462from[5,10)to[5,11), enabling use of version 10.* without changing any runtime code.Reviewed by Cursor Bugbot for commit 3078c30. Bugbot is set up for automated code reviews on this repo. Configure here.