Skip to content

feat: Update OpenAI runners to implement Runner protocol returning RunnerResult#149

Open
jsonbailey wants to merge 1 commit intojb/aic-2388/managed-resultfrom
jb/aic-2388/openai-runner-protocol
Open

feat: Update OpenAI runners to implement Runner protocol returning RunnerResult#149
jsonbailey wants to merge 1 commit intojb/aic-2388/managed-resultfrom
jb/aic-2388/openai-runner-protocol

Conversation

@jsonbailey
Copy link
Copy Markdown
Contributor

@jsonbailey jsonbailey commented Apr 28, 2026

Summary

  • `OpenAIModelRunner` and `OpenAIAgentRunner` now formally inherit from the `Runner` protocol class.
  • `OpenAIModelRunner.run()` implements the unified `Runner` protocol; returns `RunnerResult` with `content`, `metrics`, `raw`, and `parsed` fields. Structured output is supported via the `output_type` parameter.
  • `OpenAIAgentRunner.run()` updated to return `RunnerResult`; populates `tool_calls` in `LDAIMetrics` from observed openai-agents `ToolCallItem`s.
  • Legacy `invoke_model()` and `invoke_structured_model()` removed — the deprecated type definitions (`ModelRunner`, `ModelResponse`, etc.) are kept in `server-ai` for provider CI compatibility until a cleanup PR removes them.

Stacking

Stacked on top of `jb/aic-2388/managed-result` (PR #148).

Test plan

  • `make test-openai` — all OpenAI provider tests pass
  • `make test` — all tests across server-ai, langchain, and openai packages pass

🤖 Generated with Claude Code

@jsonbailey jsonbailey force-pushed the jb/aic-2388/managed-result branch from bd4cd68 to 45441da Compare April 29, 2026 13:14
@jsonbailey jsonbailey force-pushed the jb/aic-2388/openai-runner-protocol branch from f1845b4 to 94f09ee Compare April 29, 2026 13:14
@jsonbailey jsonbailey force-pushed the jb/aic-2388/managed-result branch from 45441da to 27bcfc0 Compare April 29, 2026 13:18
@jsonbailey jsonbailey force-pushed the jb/aic-2388/openai-runner-protocol branch from 94f09ee to 8463109 Compare April 29, 2026 13:19
@jsonbailey jsonbailey force-pushed the jb/aic-2388/managed-result branch from 27bcfc0 to ff47ec2 Compare April 29, 2026 13:22
@jsonbailey jsonbailey force-pushed the jb/aic-2388/openai-runner-protocol branch 2 times, most recently from eacddee to 842e4e6 Compare April 29, 2026 13:46
@jsonbailey jsonbailey force-pushed the jb/aic-2388/managed-result branch from 2ea3384 to 369242d Compare April 29, 2026 13:56
@jsonbailey jsonbailey force-pushed the jb/aic-2388/openai-runner-protocol branch from 842e4e6 to 4c95357 Compare April 29, 2026 13:56
@jsonbailey jsonbailey force-pushed the jb/aic-2388/managed-result branch from 369242d to b8d3fad Compare April 29, 2026 14:37
@jsonbailey jsonbailey force-pushed the jb/aic-2388/openai-runner-protocol branch from 4c95357 to 3f6882c Compare April 29, 2026 14:38
@jsonbailey jsonbailey force-pushed the jb/aic-2388/managed-result branch from b8d3fad to 4e28ae6 Compare April 29, 2026 16:31
@jsonbailey jsonbailey force-pushed the jb/aic-2388/openai-runner-protocol branch from 3f6882c to efeea93 Compare April 29, 2026 16:31


class OpenAIAgentRunner(AgentRunner):
class OpenAIAgentRunner:
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add the Runner protocol here vs stating it in the doc below

@@ -14,10 +14,15 @@

class OpenAIModelRunner(ModelRunner):
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be switched to the Runner protocol.

@jsonbailey jsonbailey marked this pull request as ready for review April 29, 2026 16:31
@jsonbailey jsonbailey requested a review from a team as a code owner April 29, 2026 16:31
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit efeea93. Configure here.



class OpenAIAgentRunner(AgentRunner):
class OpenAIAgentRunner:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classes don't inherit Runner protocol despite claiming implementation

Medium Severity

Both OpenAIAgentRunner and OpenAIModelRunner claim in their docstrings to implement the Runner protocol but don't actually inherit from it. This is inconsistent with OpenAIAgentGraphRunner in the same package which explicitly inherits from AgentGraphRunner. Without explicit inheritance, static type checkers cannot verify protocol conformance at definition time, and any future changes to the Runner protocol won't produce errors on these classes. The Runner protocol is imported and available in ldai.providers.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit efeea93. Configure here.

self._model_name = model_name
self._parameters = parameters

async def invoke_model(self, messages: List[LDMessage]) -> ModelResponse:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing deprecated adapters breaks backward compatibility with callers

Medium Severity

The PR description states "Legacy invoke_model() and invoke_structured_model() retained as deprecated adapters that delegate to run() for backward compatibility," but these methods are completely absent from OpenAIModelRunner. The SDK's ManagedModel.invoke() calls self._model_runner.invoke_model() directly without an isinstance check, and Judge.evaluate() calls self._model_runner.invoke_structured_model(). If an OpenAIModelRunner instance is used through either of these existing code paths, it will raise AttributeError at runtime.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit efeea93. Configure here.

@jsonbailey jsonbailey force-pushed the jb/aic-2388/openai-runner-protocol branch 3 times, most recently from 330acf1 to cd983aa Compare April 29, 2026 17:13
@jsonbailey jsonbailey force-pushed the jb/aic-2388/managed-result branch from 7352a34 to adfd9f0 Compare April 29, 2026 17:14
@jsonbailey jsonbailey force-pushed the jb/aic-2388/openai-runner-protocol branch from cd983aa to 184be64 Compare April 29, 2026 17:14
@jsonbailey jsonbailey force-pushed the jb/aic-2388/managed-result branch from adfd9f0 to b4d15df Compare April 29, 2026 17:17
@jsonbailey jsonbailey force-pushed the jb/aic-2388/openai-runner-protocol branch 4 times, most recently from 3556ba4 to b5f15b7 Compare April 29, 2026 21:07
@jsonbailey jsonbailey force-pushed the jb/aic-2388/openai-runner-protocol branch from b5f15b7 to dc86b07 Compare April 29, 2026 21:13
…nnerResult

- OpenAIModelRunner.run() implements the unified Runner protocol; returns RunnerResult
  with content, metrics (LDAIMetrics), raw, and parsed fields. Structured output is
  supported via the output_type parameter.
- OpenAIAgentRunner.run() updated to return RunnerResult; populates tool_calls in
  LDAIMetrics from observed openai-agents ToolCallItems.
- Legacy invoke_model() and invoke_structured_model() retained as deprecated adapters
  that delegate to run() and wrap results into ModelResponse / StructuredResponse for
  backward compatibility.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jsonbailey jsonbailey force-pushed the jb/aic-2388/openai-runner-protocol branch from dc86b07 to 2ba8406 Compare April 29, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant