chore: Make the FDv2 feature-store client wrappers internal - #508
Merged
Conversation
keelerm84
approved these changes
Aug 28, 2026
jsonbailey
changed the title
jsonbailey
changed the title
…system FeatureStoreClientWrapper lived in fdv2_common.py, which is meant for logic shared between the sync FDv2 and the async AsyncFDv2 (via _FDv2Base). This wrapper is sync-only — only fdv2.py uses it; the async side has its own wrapper in async_fdv2.py. Move it into fdv2.py, next to its sole user, and drop the now-unused imports and __all__ entry from fdv2_common.py. This mirrors the earlier FDv1 wrapper move (5948b78). Pure relocation, no behavior change.
Rename FeatureStoreClientWrapper -> _FeatureStoreClientWrapper (sync) and AsyncFeatureStoreClientWrapper -> _AsyncFeatureStoreClientWrapper (async), and drop both from their modules' __all__. They are internal helpers in ldclient.impl.datasystem, matching the FDv1 wrapper's private convention.
jsonbailey
force-pushed
the
jb/sdk-60/sync-fdv2-wrapper-relocation
branch
from
August 28, 2026 16:46
75dd5aa to
81f5933
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two related tidy-ups to the FDv2 store-client wrappers — internal helpers in
ldclient/impl/datasystem/:Relocate the sync wrapper. Move
FeatureStoreClientWrapperfromfdv2_common.pyintofdv2.py.fdv2_common.pyis for logic shared between syncFDv2and asyncAsyncFDv2(via_FDv2Base); this wrapper is sync-only (onlyfdv2.pyuses it — the async side has its own). Mirrors the earlier FDv1 wrapper move (5948b78).Make both FDv2 wrappers private. Rename
FeatureStoreClientWrapper→_FeatureStoreClientWrapper(sync) andAsyncFeatureStoreClientWrapper→_AsyncFeatureStoreClientWrapper(async), and drop both from their modules'__all__. They're internal implementation helpers, matching the FDv1 equivalent (_FeatureStoreClientWrapper, already private). Internal importers (test_cache_lifecycle.py,test_async_fdv2.py) updated.Pure internal cleanup — no behavior change, no public API change (everything is under
ldclient.impl).Validation
test_fdv2_datasystem.py,test_fdv2_persistence.py,test_cache_lifecycle.py,test_async_fdv2.py— 84 passed.Note
Overview
Internal cleanup for FDv2 persistent-store wrappers under
ldclient.impl.datasystem: no intended behavior or public API change.The sync
FeatureStoreClientWrappermoves out of sharedfdv2_common.pyintofdv2.py, since only the sync coordinator uses it (async keeps its own wrapper inasync_fdv2.py). Both sync and async wrappers are renamed to_FeatureStoreClientWrapperand_AsyncFeatureStoreClientWrapper, matching the existing FDv1 private helper, and they are removed from module__all__. Tests that construct these helpers directly are updated to the new names and import paths.Reviewed by Cursor Bugbot for commit 81f5933. Bugbot is set up for automated code reviews on this repo. Configure here.