ci: Quote the JRuby spec tag so the suite actually runs - #427
Merged
Conversation
The JRuby job has been running zero of the 1046 specs. The intent was to
skip only the three spec files tagged flaky, which is 33 examples, and run
the other 1013. Instead RuboCop was the only thing the job exercised.
GITHUB_ENV stores a value literally, so the single quotes in
echo "SPEC_TAGS=-t '~flaky'" >> $GITHUB_ENV
became part of the value. Unquoted $SPEC_TAGS then split into -t and
'~flaky', and RSpec read a tag whose name starts with a quote rather than
a tilde. A tilde only negates as the first character, so this asked for an
inclusion filter on a tag nothing carries:
Run options: include {:"'~flaky'"=>true}
All examples were filtered out
0 examples, 0 failures
Storing a bare ~flaky does not work either, because it undergoes tilde
expansion and fails with "no such user or named directory: flaky". So the
value holds the tag alone and the quoting happens where the argument is
built.
Run options: exclude {:flaky=>true}
1013 examples, 0 failures
Verified under bash, the shell CI uses. With SPEC_TAGS unset, which is
every CRuby and Windows job, the command still runs all 1046 examples, so
those jobs do not change.
The suite has not run on JRuby since the release-please migration in
5627f3a, dated 2023-12-01, so this exposes it there for the first time in
roughly two years. Any failures it surfaces are pre-existing.
keelerm84
marked this pull request as ready for review
August 27, 2026 17:10
kinyoklion
approved these changes
Aug 27, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JRuby job has been running zero of the 1046 specs. The intent was to
skip only the three spec files tagged flaky, which is 33 examples, and run
the other 1013. Instead RuboCop was the only thing the job exercised.
GITHUB_ENV stores a value literally, so the single quotes in
echo "SPEC_TAGS=-t '~flaky'" >> $GITHUB_ENV
became part of the value. Unquoted $SPEC_TAGS then split into -t and
'~flaky', and RSpec read a tag whose name starts with a quote rather than
a tilde. A tilde only negates as the first character, so this asked for an
inclusion filter on a tag nothing carries:
Run options: include {:"'~flaky'"=>true}
All examples were filtered out
0 examples, 0 failures
Storing a bare ~flaky does not work either, because it undergoes tilde
expansion and fails with "no such user or named directory: flaky". So the
value holds the tag alone and the quoting happens where the argument is
built.
Run options: exclude {:flaky=>true}
1013 examples, 0 failures
Verified under bash, the shell CI uses. With SPEC_TAGS unset, which is
every CRuby and Windows job, the command still runs all 1046 examples, so
those jobs do not change.
The suite has not run on JRuby since the release-please migration in
5627f3a, dated 2023-12-01, so this exposes it there for the first time in
roughly two years. Any failures it surfaces are pre-existing.
Note
Overview
Fixes the JRuby CI job so RSpec actually runs instead of filtering out every example. The flaky-skip path had been writing
-t '~flaky'intoGITHUB_ENV, which kept the quotes in the value and made RSpec look for a bogus tag—0 of 1046 specs ran.The action now stores only
~flakyinSPEC_TAGSand passes it at invoke time asbundle exec rspec spec ${SPEC_TAGS:+--tag "$SPEC_TAGS"}, so quoting avoidsGITHUB_ENVliteral-quote issues and shell tilde expansion. WhenSPEC_TAGSis unset (CRuby/Windows), the command is unchanged and still runs the full suite.Reviewed by Cursor Bugbot for commit 14beea5. Bugbot is set up for automated code reviews on this repo. Configure here.