fix: keep transient WMI failures in the tray timer from crashing the app#929
Merged
Conversation
laurentiu021
force-pushed
the
fix/p2-tray-wmi-crash
branch
from
7d05496 to
b9891b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The system-tray tooltip refreshes CPU/RAM/uptime on a background timer.
OnTimerTickisasync void, andUpdateTooltipAsync→SystemInfoService.CaptureAsync()runs WMI queries. WMI commonly throwsCOMExceptionon transient faults (RPC server unavailable0x800706BA, repository errors), whichUpdateTooltipAsyncdid NOT catch — so it escaped the async-void handler and crashed the whole app.Changes (
TrayIconService)catch (COMException)arm toUpdateTooltipAsync(logs the HRESULT, skips the tick), alongside the existingManagementException/InvalidOperationExceptioncatches.catch (Exception)toOnTimerTick(logged) — an async-void background poller must never let anything escape and take the process down.Build: 0 warnings / 0 errors. Version 1.20.39. (Stacks on #927; will rebase to final version before merge.)