fix: move blocking shortcut-delete and app-list scans off the UI thread, gate log refresh#935
Merged
Merged
Conversation
laurentiu021
force-pushed
the
fix/p2-ui-thread-offload
branch
from
83fd342 to
8b2f6d9
Compare
laurentiu021
force-pushed
the
fix/p2-ui-thread-offload
branch
from
b4cdc37 to
7ab19a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three UI-responsiveness fixes (P2).
Changes
async DeleteSelectedAsync; the synchronousSHFileOperationbatch delete now runs viaTask.Run, so deleting many shortcuts doesn't freeze the window.async RefreshInstalledAppsAsync; the full HKLM uninstall-tree enumeration now runs viaTask.Run(...).ConfigureAwait(true), off the UI thread.[RelayCommand(CanExecute = nameof(NotBusy))]+PropertyChangedobserver onIsBusy; a second refresh started while one is running could let the cancelled run's queued UI batches pollute the newEntrieslist. The button is now disabled while scanning.Tests
LogsViewModelTests.RefreshCommand_DisabledWhileBusyasserts the gate (allowed idle → blocked busy → allowed again).Task.Runoffloads are behavior-preserving (same work, off-thread); covered by existing VM tests.Notes
ApplyPresetand PingStop-blocks-UI findings are deferred — they touch sharedNetworkSharedState/RestartExplorer flows and warrant separate, carefully-verified PRs.Build: main + tests 0 warnings / 0 errors. Version 1.20.42. (Stacks on #930/#933; will rebase before merge.)